Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to promisify-port.js #127

Merged
merged 3 commits into from
May 11, 2023

Conversation

marc136
Copy link
Contributor

@marc136 marc136 commented May 8, 2023

This PR is a step towards #125, and adds types to lib/promisify-port.js.

I was not sure about the descriptive comments, feel free to change them however you see fit.

I never wrote jsdoc comments to such an extent before, adding a .d.ts file would have been easier for me.
Thank you for the challenge 😆

@marc136
Copy link
Contributor Author

marc136 commented May 9, 2023

I realized later, that adding .d.ts definition files is also possible. So I extracted the hardly readable JSDoc types to types/promisify-port.d.ts.

Copy link
Owner

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marc136! Thanks for looking at this!
This all looks good to me 😊
(And yes, the .d.ts. files are nicer 😁 )

@jfmengels jfmengels merged commit 1667809 into jfmengels:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants