Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

found the missing tests, back to parity #85

Merged
merged 3 commits into from
Feb 16, 2024
Merged

found the missing tests, back to parity #85

merged 3 commits into from
Feb 16, 2024

Conversation

jflo
Copy link
Owner

@jflo jflo commented Feb 16, 2024

PR description

Fixed Issue(s)

@jflo
found the missing tests, back to parity
71d4f3c 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
Merge branch 'main' into testResultsArtifacts
0fb578f
@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

RoboCopsGoneSock
RoboCopsGoneSock approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@RoboCopsGoneSock RoboCopsGoneSock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that'd do it

@jflo
rename to avoid consolidation status collision with workflow name
cc301a6 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@RoboCopsGoneSock RoboCopsGoneSock merged commit 0072e9e into main Feb 16, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoboCopsGoneSock RoboCopsGoneSock RoboCopsGoneSock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jflo @RoboCopsGoneSock