wait for or cancel running asyncio tasks in an event emitter #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
add comment
only cancel tasks that are still pending
jfhbrook
force-pushed
the
asyncio-wait-cancel
branch
from
b0e228e to
6b54580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off #167:
wait_for_complete,cancelandcomplete./tests/test_async.pybecause a prior iteration of this library supported both in the same event emitter abstraction. Now./tests/test_async.pyhas been renamed to./tests/test_asyncio.pyand Twisted tests have been moved into./tests/test_twisted.pywith the other Twisted testsI also investigated adding analogous features to other event emitters, but I don't think the other supported frameworks quite have the same execution/cancelation model as asyncio - certainly none of them hold explicit references to their futures.