Skip to content

Shiftclick #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Shiftclick #10

wants to merge 4 commits into from

Conversation

jcb91
Copy link
Collaborator

@jcb91 jcb91 commented Jan 21, 2018

jcb91 added 3 commits January 21, 2018 23:15
@jcb91
[various] use Jupyter.notebook.config instance, where appropriate
699f31b 
to avoid reloading (from server!) the same config file for each nbextension.
In most cases this also means we don't need to require the 'services/config' module any longer.
@jcb91
[requirejs] don't use commonjs wrapper
15d7e02 
as it works by searching through the module definition function's toString representation, the commonjs style requirejs wrapper is slower, and prone to subtle errors. We don't actually need it anywhere, so use regular requirejs define calls instead.
@jcb91
[kernel_exec_on_cells] make shift-click on button autoformat all cells
a42b3ef 
as discussed in ipython-contrib/jupyter_contrib_nbextensions#1202 (comment)
@jcb91 jcb91 mentioned this pull request Jan 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcb91