Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hooked up wasm and was able to build something.
Unfortunatly the libstdc++ we have does not have bit cast.
emscripten moved to libc++ I think: https://github.com/emscripten-core/emscripten/blob/4c70173bf44c885801b13a12ce1777152ab4f68e/system/lib/libcxx/include/bit#L53
but that does not have bit_cast either (somehow!)
So I think updating emscrpiten at the moment won't solve the issue.
I don't think we won't to hack around
bit_cast
- so I'd say - let's merge the toolchain so we don't have to start from scratch and wait.