Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RawRecord PR follow-up - address DGollings' comment #139

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Conversation

jf-tech
Copy link
Owner

@jf-tech jf-tech commented Jan 10, 2021

a follow-up from #138

@jf-tech
Copy link
Owner Author

jf-tech commented Jan 10, 2021

FYI @DGollings

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #139 (2a64f8e) into master (4aa56d6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         1976      1977    +1     
=========================================
+ Hits          1976      1977    +1     
Impacted Files Coverage Δ
transform.go 100.00% <ø> (ø)
extensions/omniv21/ingester.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa56d6...2a64f8e. Read the comment docs.

@jf-tech
Copy link
Owner Author

jf-tech commented Jan 13, 2021

Ping @DGollings

@DGollings
Copy link

oh sorry, I thought you were waiting for one of the reviewers. Was already checking whether release 0.0.9 was out. Looks good to me though,

@jf-tech jf-tech merged commit 675471c into master Jan 13, 2021
@jf-tech jf-tech deleted the rawrecordiface branch January 13, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants