Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12 - Remove CGI servlet #9516

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Jetty 12 - Remove CGI servlet #9516

merged 4 commits into from
Mar 29, 2023
+3 −1,200

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Mar 17, 2023

Removing old CGI servlet support.

We have FastCGI servlet that is better maintained.

@joakime joakime added this to the 12.0.x milestone Mar 17, 2023
@joakime joakime requested a review from sbordet March 17, 2023 16:05
@joakime joakime self-assigned this Mar 17, 2023
@sbordet sbordet self-requested a review March 21, 2023 08:47
sbordet
sbordet requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed a reference to CGI in jetty-ee10-demo-jetty-webapp's web.xml.
Same for ee9.

@joakime joakime merged commit 6ce5a0f into jetty-12.0.x Mar 29, 2023
@joakime joakime deleted the fix/12.0.x/remove-cgi-servlets branch March 29, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees

@joakime joakime

Labels
None yet
Projects
None yet
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@joakime @sbordet