Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow start.jar to list enabled modules #5683

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Allow start.jar to list enabled modules #5683

merged 1 commit into from
Nov 17, 2020

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Nov 17, 2020

Fixes #5679 and #5680 listing modules

  • Updated usage to show that --list-config lists the enabled Modules
  • fixed unsupported operation in --list-all-modules
  • list enabled modules with default --list-module

@gregw
Fixes #5679 and #5680 listing modules
f16a7e1 
+ Updated usage to show that --list-config lists the enabled Modules
+ fixed unsupported operation in --list-all-modules
+ list enabled modules with default --list-module
@gregw gregw requested a review from janbartel November 17, 2020 15:05
@gregw gregw linked an issue Nov 17, 2020 that may be closed by this pull request
No way to see which modules are enabled for the distro #5680
Closed
joakime
joakime approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple.
LGTM.

@gregw gregw merged commit 41a7d8b into jetty-10.0.x Nov 17, 2020
@joakime joakime deleted the jetty-10.0.x-5679-list-all-modules branch November 26, 2020 16:01
@joakime joakime changed the title Fixes #5679 and #5680 listing modules Allow start.jar to list enabled modules Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@janbartel janbartel Awaiting requested review from janbartel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to see which modules are enabled for the distro Distro argument --list-all-modules does not work
2 participants
@gregw @joakime