Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5254 List/Show modules #5257

Merged
merged 4 commits into from
Sep 14, 2020
Merged

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Sep 11, 2020

For #5254

  • simplified --list-modules output
  • added --show-module

Signed-off-by: Greg Wilkins gregw@webtide.com

 * simplified --list-modules output
 * added --show-module

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw requested review from sbordet and joakime September 11, 2020 14:59
@gregw
Copy link
Contributor Author

gregw commented Sep 11, 2020

I believe the CI failures are unrelated

@gregw gregw mentioned this pull request Sep 11, 2020
@gregw
Copy link
Contributor Author

gregw commented Sep 14, 2020

@sbordet @joakime bump

Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, while we are at it, we should really fix all the first lines of all the modules.
There are some that are 2 sentences on the same like (should be 1), or 1.5 sentences (should be 1), and we should be consistent (like in javadocs) in using the 3rd person, i.e. not "Enable the Server thread pool." but "Enables the Server thread pool."

Alternatively, we should open a new issue for fixing the descriptions.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw
Copy link
Contributor Author

gregw commented Sep 14, 2020

I've had an initial go at improving the modules, but I think I'll start another process to have all the module descriptions improved.

@joakime
Copy link
Contributor

joakime commented Sep 14, 2020

I've had an initial go at improving the modules, but I think I'll start another process to have all the module descriptions improved.

As a separate PR? or in this one?

@gregw
Copy link
Contributor Author

gregw commented Sep 14, 2020

I've done an initial pass in this PR. But I think the full cleanup needs to be passed to the doco team to :

  • ensure the same voice is used for all descriptions.
  • it ties into the doco with same descriptions
  • the links are correct etc.

So i don't want it to hold back this issue.

@gregw gregw merged commit 780e120 into jetty-10.0.x Sep 14, 2020
@gregw gregw deleted the jetty-10.0.x-5254-show-module branch September 14, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants