-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5254 List/Show modules #5257
Conversation
* simplified --list-modules output * added --show-module Signed-off-by: Greg Wilkins <gregw@webtide.com>
I believe the CI failures are unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, while we are at it, we should really fix all the first lines of all the modules.
There are some that are 2 sentences on the same like (should be 1), or 1.5 sentences (should be 1), and we should be consistent (like in javadocs) in using the 3rd person, i.e. not "Enable the Server thread pool." but "Enables the Server thread pool."
Alternatively, we should open a new issue for fixing the descriptions.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
I've had an initial go at improving the modules, but I think I'll start another process to have all the module descriptions improved. |
As a separate PR? or in this one? |
I've done an initial pass in this PR. But I think the full cleanup needs to be passed to the doco team to :
So i don't want it to hold back this issue. |
For #5254
Signed-off-by: Greg Wilkins gregw@webtide.com