Fixes #4577 IPAccessHandler in context #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes and tests #4577 IPAccessHandler in context by using target instead of pathInfo for path matching. Signed-off-by: Greg Wilkins <gregw@webtide.com>
This was referenced Feb 17, 2020
Closed
|
The behaviour is il defined if this handler is within a context and a named dispatch is done. As t his is a deprecated handler, I am not inclined to define this behaviour. |
|
Class |
sbordet
requested changes
Feb 21, 2020
jetty-server/src/test/java/org/eclipse/jetty/server/handler/IPAccessHandlerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/handler/IPAccessHandlerTest.java
Show resolved
Hide resolved
Updates from review. Signed-off-by: Greg Wilkins <gregw@webtide.com>
|
Looking at the commit comments for InetAccessHandler, they suggest that URI mapping was intended to be added eventually. I'll open a new issue to track it. (edit see: #4598) |
Match on full URI path rather than target. Signed-off-by: Greg Wilkins <gregw@webtide.com>
sbordet
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and tests #4577 IPAccessHandler in context by using target instead of pathInfo for path matching.
Signed-off-by: Greg Wilkins gregw@webtide.com