Issue #4247 use context default for samesite cookie attribute #4512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <janb@webtide.com>
gregw
requested changes
Jan 28, 2020
jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookie.java
Outdated
Show resolved
Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookie.java
Outdated
Show resolved
Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookie.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Bartel <janb@webtide.com>
gregw
approved these changes
Jan 29, 2020
janbartel
deleted the
jetty-9.4.x-4247-container-default-samesite-cookie
branch
janbartel
added a commit
that referenced
this pull request
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement allowing a default value for SameSite cookie attribute to be set on a context attribute. If a cookie is added to the response that has SameSite=null, then we use the context default value instead. If the context default value is null, then the cookie remains as SameSite=null.
Closes #4247