Issue #3051 - New Simplified Jenkinsfile #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to fix issue #2458 after this (removing jdk9 and jdk10 builds from CI) |
joakime
changed the title
|
Referencing Issue #3051 (typo in original commit) |
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
force-pushed
the
jetty-9.4.x-issue-3015-simplified-Jenkinsfile
branch
from
9b5e0f6
to
7b8bda8
Compare
sbordet
reviewed
Nov 2, 2018
| // in case of change update method isMainBuild | ||
| def jdks = ["jdk8","jdk9","jdk10","jdk11"] | ||
| def mainJdk = "jdk8" | ||
| def jdks = [mainJdk, "jdk9", "jdk10", "jdk11"] |
There was a problem hiding this comment.
jdk9 and jdk10 are not removed?
There was a problem hiding this comment.
not yet in jetty-9.4.x (maybe could make sense? I don't really have strong opinion)
There was a problem hiding this comment.
Removing jdk9 and jdk10 will be a different PR/commit (it's a different issue: #2458)
olamy
approved these changes
Nov 2, 2018
| // in case of change update method isMainBuild | ||
| def jdks = ["jdk8","jdk9","jdk10","jdk11"] | ||
| def mainJdk = "jdk8" | ||
| def jdks = [mainJdk, "jdk9", "jdk10", "jdk11"] |
There was a problem hiding this comment.
not yet in jetty-9.4.x (maybe could make sense? I don't really have strong opinion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com