Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SymlinkAllowedResourceAliasChecker for use with CombinedResource #12724

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Fix SymlinkAllowedResourceAliasChecker for use with CombinedResource #12724

merged 3 commits into from
Jan 28, 2025

Conversation

lachlan-roberts
Copy link
Contributor

  • added a new test case AliasCheckerMultipleResourceTest#testCombinedResources to reproduce an issue with the SymlinkAllowedResourceAliasChecker.
  • proposed a simple fix to SymlinkAllowedResourceAliasChecker which allows the test to pass.
  • cleaned up the AliasChecker tests by extracting some methods into a separate class.

@lachlan-roberts
Add new test case for symlink AliasChecker with CombinedResources
bb30659 
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
@lachlan-roberts
Cleanup AliasCheckerSymlinkTest by extending AliasCheckerTestBase
6a75670 
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
@lachlan-roberts
add fix for CombinedResources with symlink AliasChecker
66984c9 
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
@joakime
Copy link
Contributor

joakime commented Jan 21, 2025

@lachlan-roberts what are the labels?
what project is this for?
Is there an Issue to associate with this PR?

@lachlan-roberts lachlan-roberts added the Sponsored This issue affects a user with a commercial support agreement label Jan 22, 2025
@lachlan-roberts lachlan-roberts self-assigned this Jan 22, 2025
gregw
gregw approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks simple enough!

@joakime joakime added the Bug For general bugs on Jetty side label Jan 24, 2025
@lachlan-roberts lachlan-roberts merged commit 87d5482 into jetty-12.0.x Jan 28, 2025
10 checks passed
@lachlan-roberts lachlan-roberts deleted the fix/aliasCheckerCombinedResource branch January 28, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@joakime joakime Awaiting requested review from joakime

Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
Jetty 12.0.17
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lachlan-roberts @joakime @gregw