Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #12315 fix flakey session AsyncTest #12316

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Issue #12315 fix flakey session AsyncTest #12316

merged 1 commit into from
Sep 26, 2024

Conversation

janbartel
Copy link
Contributor

Closes #12315

Session AsyncTest needs to call SessionCache.setFlushOnResponseCommit(true) before it can test results of session operations after a response returns.

@janbartel janbartel added Bug For general bugs on Jetty side flaky-test labels Sep 25, 2024
@janbartel janbartel requested a review from gregw September 25, 2024 22:17
@janbartel janbartel self-assigned this Sep 25, 2024
gregw
gregw approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe default to true 12.1.x?

@janbartel
Copy link
Contributor Author

Maybe default to true 12.1.x?

Will do that in another PR.

@janbartel janbartel merged commit ba0ba99 into jetty-12.0.x Sep 26, 2024
13 checks passed
@janbartel janbartel deleted the jetty-12.0.x-12315-session-asynctest branch September 26, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@gregw gregw gregw approved these changes

Assignees

@janbartel janbartel

Labels
Bug For general bugs on Jetty side flaky-test
Projects
No open projects
Jetty 12.0.14
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncTest session is flakey
3 participants
@janbartel @olamy @gregw