Optimize request buffer release #12239 #12240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to #12228. In this PR, the responsibility to release the buffers is in 2 methods: onFillable() (called when network data is available, and to process the next request) and parseAndFillForContent() (called from Request.read()). Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Using the request executor to dispatch onFillable(). Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Ensure there is a request before accessing components
Release buffer after consumeAvailable
Still problems
…ary. Fixed failing tests that were not completing the Handler Callback. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Release request buffer before handling when there is no content
gregw
requested review from
sbordet and
lorban
and removed request for
sbordet
Release request buffer before handling when there is no content
…fferRelease # Conflicts: # jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java
gregw
commented
Sep 6, 2024
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java
Show resolved
Hide resolved
gregw
commented
Sep 6, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java
Show resolved
Hide resolved
gregw
commented
Sep 6, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java
Show resolved
Hide resolved
sbordet
requested changes
Sep 9, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java
Outdated
Show resolved
Hide resolved
|
@gregw this branch seems to reliably improve perf by about 5%. Here is a profiling run of vanilla 12.1.x: https://jenkins.webtide.net/job/load_testing/job/jetty-profiler-12.1.x/10 |
…12239/optimizeRequestBufferRelease
lorban
approved these changes
Sep 16, 2024
sbordet
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12239 by releasing an empty request buffer when it is known there is no content to read.