Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12.1.x various updates to demos #12089

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

janbartel
Copy link
Contributor

  • Use standard spec api jars for jetty demos
  • Remove some printlns from demos
  • Remove use of jetty util class StringUtil

@janbartel janbartel self-assigned this Jul 25, 2024
@janbartel janbartel changed the base branch from jetty-12.0.x to jetty-12.1.x July 25, 2024 04:59
@janbartel janbartel marked this pull request as ready for review July 26, 2024 07:22
@janbartel janbartel requested a review from olamy July 26, 2024 07:22
@janbartel
Copy link
Contributor Author

@olamy the remaining uses of jetty-util classes are deliberately testing the ability of the webappclassloader to see jetty classes that are in WEB-INF/lib, or in the case of the async-rest demo, it's using the jetty-util-ajax utils to parse json.

@janbartel
Copy link
Contributor Author

@olamy nudge?

Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@janbartel janbartel merged commit 35bf336 into jetty-12.1.x Jul 29, 2024
10 checks passed
@janbartel janbartel deleted the jetty-12.1.x-various-updates-to-demos branch July 29, 2024 08:54
@olamy olamy mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants