Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12.0.x xmlconfig prefers interfaces #11901

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

janbartel
Copy link
Contributor

Fixes #11895.

Tentative fix to improve ordering of method matches so that:

  • methods with fewer args are preferred
  • methods with primitive args are preferred
  • methods with non-varargs are preferred
  • methods with class args (that are not the Object.class) are preferred
  • methods with interface args or class args preference the most derived type

@janbartel janbartel self-assigned this Jun 11, 2024
@gregw gregw requested review from gregw and sbordet October 2, 2024 22:07
@joakime
Copy link
Contributor

joakime commented Oct 23, 2024

@janbartel rebase against jetty-12.1.x

@gregw
Copy link
Contributor

gregw commented Oct 24, 2024

I think this is a good change for 12.1, I'm not so worried by this now (cue disaster!)

@gregw
Copy link
Contributor

gregw commented Oct 29, 2024

@janbartel can you rebase this to 12.1, I think it is a good change to make.

@janbartel janbartel force-pushed the jetty-12.0.x-xmlconfig-prefers-interfaces branch from bc0452d to 50343ab Compare October 30, 2024 00:44
@janbartel
Copy link
Contributor Author

Rebase done.

@gregw gregw changed the base branch from jetty-12.0.x to jetty-12.1.x October 30, 2024 02:31
@janbartel janbartel requested a review from gregw October 30, 2024 05:49
@janbartel janbartel marked this pull request as ready for review October 30, 2024 20:56
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbartel janbartel merged commit 0d3a4f2 into jetty-12.1.x Oct 31, 2024
10 checks passed
@janbartel janbartel deleted the jetty-12.0.x-xmlconfig-prefers-interfaces branch October 31, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

XmlConfiguration should prefer exact class match rather than interface match
3 participants