Fixes #11892 - mtls not working with http/3. #11900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client certificate is now exposed in QuicheConnection, so that it can be returned by QuicStreamEndPoint.getSslSessionData(). Not much else is exposed by Quiche, so not much else that we can provide to applications, for example no TLS session id, no cipher suite, etc. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
requested changes
Jun 11, 2024
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
previously approved these changes
Jun 11, 2024
… foreign dependency is in the class-path. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
previously approved these changes
Jun 11, 2024
gregw
previously approved these changes
Jun 11, 2024
| @@ -423,6 +427,23 @@ private void finishOutwardClose(Throwable failure) | |||
| } | |||
| } | |||
|
|
|||
| public X509Certificate[] getPeerCertificates() | |||
There was a problem hiding this comment.
Maybe javadoc that only the top/last/single certificate will be returned.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
added a commit
that referenced
this pull request
Jun 19, 2024
The client certificate is now exposed in QuicheConnection, so that it can be returned by QuicStreamEndPoint.getSslSessionData(). Not much else is exposed by Quiche, so not much else that we can provide to applications, for example no TLS session id, no cipher suite, etc. Fixed --enable-native-access command line option to run tests, as the foreign dependency is in the class-path. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client certificate is now exposed in QuicheConnection, so that it can be returned by QuicStreamEndPoint.getSslSessionData().
Not much else is exposed by Quiche, so not much else that we can provide to applications, for example no TLS session id, no cipher suite, etc.