-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #11266 - allow context attributes to be used to configure max form (content size / keys) #11898
Issue #11266 - allow context attributes to be used to configure max form (content size / keys) #11898
Conversation
…orm (content size / keys) * Allows these common configurations to be set via WEB-INF/web.xml without the need for a WEB-INF/jetty-web.xml
@janbartel is this approach acceptable? This PR is currently draft, as I still need to write some documentation and new unit tests for these new techniques. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need to do this now that we can accommodate all different environment versions of WEB-INF/jetty-web.xml
and even a general way to apply an environment specific context xml file to every deployment to that environment.
I have no idea what you are referencing. The documentation, and the code do not show alternate jetty-web.xml behaviors on the |
This was discussed at #11266 (comment) but I'm not sure it's been implemented already. If it has then that's awesome as I could use it on XWiki (we're still stuck ATM). Thx |
I forgot we already had an issue for backporting the new environment specific |
@janbartel cool, thx. I hope that Jetty 12.1 will be released soon or that a 12.0.x release with #11774 will be done soon :) Right now we're stuck on Jetty 10 (as XWiki cannot move to jakarta EE yet), which is why we're keen to move to Jetty 12.x. Thx again |
@vmassol 12.0.11 should be around soon (we hope mid/late next week) |
Great, thanks Olivier! :) (I hope it'll contain #11774 which is still open ATM) |
@janbartel @joakime @olamy Actually I'm not sure if this issue will help us since our problem is the ability to deploy the same XWiki WAR to work both in Jetty 10 and 12 (see #11266). AFAIU the code from this issue just adds a new way to configure jetty through OTOH implementing #11266 (comment) would work since it's backward-compatible (Jetty 10 would use Or do you plan to backport the ability to configure Jetty from Thx |
Replacement of PR #11274
WEB-INF/web.xml
without the need for aWEB-INF/jetty-web.xml