Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump jetty-setuid to 2.0.1 #10406

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Bump jetty-setuid to 2.0.1 #10406

merged 2 commits into from
Aug 25, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Aug 25, 2023

Replace jetty-setuid-java and the various jetty-setuid-native artifacts with the new jetty-setuid-jna artifact.

@joakime joakime added Bug For general bugs on Jetty side Jetty 12 labels Aug 25, 2023
@joakime joakime requested a review from lorban August 25, 2023 14:17
@joakime joakime self-assigned this Aug 25, 2023
lorban
lorban requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have two questions I'd like to be reassured about.

jetty-home/pom.xml Outdated Show resolved Hide resolved
jetty-home/src/main/resources/modules/setuid.mod Outdated Show resolved Hide resolved
@joakime joakime marked this pull request as draft August 25, 2023 15:21
@joakime
Copy link
Contributor Author

joakime commented Aug 25, 2023

This is not ready to review (yet)

I'd like to get the PR at jetty/jetty-toolchain#281 merged and a new jetty-setuid-jna 2.0.1 released to make integrating easier on this side.

@lorban
Copy link
Contributor

lorban commented Aug 25, 2023

I approved jetty/jetty-toolchain#281, please go on with this PR.

@joakime joakime changed the title Bump jetty-setuid to 2.0.0 Bump jetty-setuid to 2.0.1 Aug 25, 2023
@joakime joakime requested a review from lorban August 25, 2023 17:41
lorban
lorban approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joakime joakime marked this pull request as ready for review August 25, 2023 18:47
@joakime joakime merged commit 053d44e into jetty-12.0.x Aug 25, 2023
2 checks passed
@joakime joakime deleted the fix/12.0.x/setuid-jna branch August 25, 2023 18:47
@joakime joakime mentioned this pull request Aug 28, 2023
Closed
@joakime joakime linked an issue Aug 28, 2023 that may be closed by this pull request
Update Jetty lib-setuid for Jetty 12 #10279
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorban lorban lorban approved these changes

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Jetty lib-setuid for Jetty 12
2 participants
@joakime @lorban