Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong websocket artifact Jetty 12.x docs #10275

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

zugazagoitia
Copy link
Contributor

The jetty websocket section of the programming guide indicates the websocket-jetty-api and websocket-jetty-server artifact dependencies that should be jetty-websocket-jetty-api and jetty-websocket-jetty-server respectively.

@joakime
Copy link
Contributor

joakime commented Aug 9, 2023

@zugazagoitia
Copy link
Contributor Author

I have signed the ECA but the status does not change, is there anything specific I should do?

@joakime
Copy link
Contributor

joakime commented Aug 9, 2023

I have signed the ECA but the status does not change, is there anything specific I should do?

The most common cause is that you are using a different email address at eclipse then you used to create the commit for this PR.

Look at the email address on your commit -> https://github.com/eclipse/jetty.project/commit/ed59dff373aa8b4b9f9d58f7c0b7190b81e3a1dd.patch
Does it match what you are using at Eclipse?

@zugazagoitia
Copy link
Contributor Author

zugazagoitia commented Aug 9, 2023

Look at the email address on your commit -> https://github.com/eclipse/jetty.project/commit/ed59dff373aa8b4b9f9d58f7c0b7190b81e3a1dd.patch Does it match what you are using at Eclipse?

It does match, I made sure of it. You can check my Eclipse profile here. Is there anything else I can try?

Else you can just close this pr and fix it yourself, I have no problem with it.

It just worked now, it needed some more time.

@joakime joakime merged commit 1a9f428 into jetty:jetty-12.0.x Aug 9, 2023
2 checks passed
@joakime
Copy link
Contributor

joakime commented Aug 9, 2023

Merged! Thanks for your patience. 😃

@zugazagoitia zugazagoitia deleted the zugazagoitia-patch-1 branch August 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants