Issue #10158 - tests to prove out XML only based deployment technique #10209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbartel
approved these changes
Aug 16, 2023
sbordet
requested changes
Aug 17, 2023
|
|
||
| String[] argsStart = { | ||
| "jetty.http.port=" + httpPort, | ||
| "jetty.httpConfig.port=" + httpPort |
There was a problem hiding this comment.
This property jetty.httpConfig.port does not exist, remove it.
There was a problem hiding this comment.
This property is present in many other places as well.
I'll make a different PR to correct all of the deprecated properties.
There was a problem hiding this comment.
Opened Issue #10334
sbordet
approved these changes
Aug 17, 2023
gregw
added a commit
that referenced
this pull request
Aug 27, 2023
Implemented a simpler default environment algorithm where an application that does not specify an environment is always attempted in the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test case to
DistributionTeststo show that an XML based deployment (with the WAR outside of the${jetty.base}/webapps/directory) is possible.