-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #10158 - tests to prove out XML only based deployment technique #10209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it builds, it's fine.
|
||
String[] argsStart = { | ||
"jetty.http.port=" + httpPort, | ||
"jetty.httpConfig.port=" + httpPort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property jetty.httpConfig.port
does not exist, remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property is present in many other places as well.
I'll make a different PR to correct all of the deprecated properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened Issue #10334
Implemented a simpler default environment algorithm where an application that does not specify an environment is always attempted in the default.
Adding test case to
DistributionTests
to show that an XML based deployment (with the WAR outside of the${jetty.base}/webapps/
directory) is possible.