Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3-server is leaking the Jetty logging service to web applications #9795

Closed
cowwoc opened this issue May 24, 2023 · 2 comments · Fixed by #9800
Closed

http3-server is leaking the Jetty logging service to web applications #9795

cowwoc opened this issue May 24, 2023 · 2 comments · Fixed by #9800
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@cowwoc
Copy link
Contributor

cowwoc commented May 24, 2023

Related to #6112, I see that org.eclipse.jetty.http3:http3-common:jar:11.0.14:compile depends on org.eclipse.jetty.quic:quic-common:jar:11.0.14:compile which depends on org.eclipse.jetty:jetty-slf4j-impl:jar:11.0.14:compile which causes the following problem at runtime:

SLF4J: Class path contains multiple SLF4J providers.
SLF4J: Found provider [org.eclipse.jetty.logging.JettyLoggingServiceProvider@37374a5e]
SLF4J: Found provider [ch.qos.logback.classic.spi.LogbackServiceProvider@4671e53b]
SLF4J: See https://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual provider is of type [org.eclipse.jetty.logging.JettyLoggingServiceProvider@37374a5e]
@cowwoc cowwoc added the Bug For general bugs on Jetty side label May 24, 2023
@joakime
Copy link
Contributor

joakime commented May 24, 2023

Unfortunate, for now just setup an exclusion.

The problem isn't in quic-common as it has a <scope>test</scope> dependency.
https://github.com/eclipse/jetty.project/blob/jetty-10.0.14/jetty-quic/quic-common/pom.xml

The problem is coming from http3-common.
https://github.com/eclipse/jetty.project/blob/jetty-10.0.15/jetty-http3/http3-common/pom.xml

Confirmed with a quick dependency:tree on the jetty-10.0.14 tag (also present in jetty-10.0.15 and HEAD)

[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ http3-common ---
[INFO] org.eclipse.jetty.http3:http3-common:jar:10.0.14
[INFO] +- org.slf4j:slf4j-api:jar:2.0.5:compile
[INFO] +- org.eclipse.jetty.http3:http3-qpack:jar:10.0.14:compile
[INFO] |  \- org.eclipse.jetty:jetty-http:jar:10.0.14:compile
[INFO] +- org.eclipse.jetty.quic:quic-common:jar:10.0.14:compile
[INFO] |  \- org.eclipse.jetty.quic:quic-quiche-common:jar:10.0.14:compile
[INFO] |     \- org.mortbay.jetty.quiche:jetty-quiche-native:jar:0.16.0:compile
[INFO] +- org.eclipse.jetty:jetty-io:jar:10.0.14:compile
[INFO] +- org.eclipse.jetty:jetty-util:jar:10.0.14:compile
[INFO] +- org.eclipse.jetty:jetty-slf4j-impl:jar:10.0.14:compile
[INFO] +- org.eclipse.jetty.toolchain:jetty-test-helper:jar:6.0:test
[INFO] |  \- org.hamcrest:hamcrest:jar:2.2:test
[INFO] \- org.junit.jupiter:junit-jupiter:jar:5.9.1:test
[INFO]    +- org.junit.jupiter:junit-jupiter-api:jar:5.9.1:test
[INFO]    |  +- org.opentest4j:opentest4j:jar:1.2.0:test
[INFO]    |  +- org.junit.platform:junit-platform-commons:jar:1.9.1:test
[INFO]    |  \- org.apiguardian:apiguardian-api:jar:1.1.2:test
[INFO]    +- org.junit.jupiter:junit-jupiter-params:jar:5.9.1:test
[INFO]    \- org.junit.jupiter:junit-jupiter-engine:jar:5.9.1:test
[INFO]       \- org.junit.platform:junit-platform-engine:jar:1.9.1:test

@joakime
Copy link
Contributor

joakime commented May 25, 2023

Opened PR #9800

joakime added a commit that referenced this issue Jun 5, 2023
* jetty-slf4j-impl is non-optional on some modules
* Using appropriate slf4j impl depending on module.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants