Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Durable Filters, Servlets and Listeners #5835

Closed
gregw opened this issue Dec 22, 2020 · 2 comments · Fixed by #6027
Closed

Review Durable Filters, Servlets and Listeners #5835

gregw opened this issue Dec 22, 2020 · 2 comments · Fixed by #6027
Assignees
@gregw
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement

Comments

@gregw
Copy link
Contributor

gregw commented Dec 22, 2020

Jetty version

9.4.x

Description

Several issues have been seen with durable filters, servlets and listeners:

  • Filters, Servlets and Listeners added via the embedded API are assumed to be durable, however if they are added during starting phase, they should be assumed to be non durable
  • non durable ServletContextListeners are removed before the contextDestroyed event is called, so it is never called for those listeners
@gregw
Copy link
Contributor Author

gregw commented Dec 22, 2020

@lachlan-roberts anything else we discussed?

gregw added a commit that referenced this issue Dec 22, 2020
@gregw
Fix #5835 Durable Filters, Servlets and Listeners
6a1bcea 
Filters, Servlets and Listeners are only durable if added prior to starting.
gregw added a commit that referenced this issue Dec 22, 2020
@gregw
Fix #5835 Durable Filters, Servlets and Listeners
1fd8caf 
For non durable ServletContextListeners ensure that initialized is called if they are added during starting and that destroyed is called.
gregw added a commit that referenced this issue Dec 22, 2020
@gregw
Fix #5835 Durable Filters, Servlets and Listeners
d72046c 
Fixed destroy order.
lachlan-roberts added a commit that referenced this issue Dec 23, 2020
@lachlan-roberts
Issue #5835 - fix tests for restarting webapp with websocket enabled
4b6930f 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Dec 23, 2020
@gregw
Fix #5835 Durable Filters, Servlets and Listeners
176e58d 
Update WebSocketUpgradeFilter to have durable configuration.
gregw added a commit that referenced this issue Dec 29, 2020
@gregw
Fix #5835 Durable Filters, Servlets and Listeners
ba34eb7 
throw ISE for SCL added after init
@gregw gregw mentioned this issue Mar 3, 2021
Closed
@gregw gregw self-assigned this Mar 3, 2021
@gregw
Copy link
Contributor Author

gregw commented Mar 3, 2021

Let's fix only in 10.

@joakime joakime added Enhancement Sponsored This issue affects a user with a commercial support agreement labels Mar 3, 2021
gregw added a commit that referenced this issue Mar 3, 2021
@gregw
Fix #5835 Durable filters and servlets
be07b88 
Fix #5835 Durable filters and servlets with a general ServletHandler cleanup
@gregw gregw mentioned this issue Mar 3, 2021
Merged
gregw added a commit that referenced this issue Mar 22, 2021
@gregw
Fix #5835 Durable filters and servlets (#6027)
c59de80 
Fix #5835 Durable filters and servlets with a general ServletHandler cleanup
update indexes after updating mapping
update mappings/indexes before destroyed listeners

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5835 Durable filters and servlets jetty/jetty.project
2 participants
@gregw @joakime