Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup XmlConfiguration WARN on Arg threadpool #4631

Closed
joakime opened this issue Mar 2, 2020 · 2 comments · Fixed by #4632
Closed

Startup XmlConfiguration WARN on Arg threadpool #4631

joakime opened this issue Mar 2, 2020 · 2 comments · Fixed by #4632
Assignees
@joakime
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Mar 2, 2020 •
edited
Loading

Originally posted by @TezzerFX in #4620 (comment)

There's a WARN message on startup about the threadpool ...

$ java -jar ../start.jar
2020-03-02 15:05:36.442:INFO::main: Logging initialized @381ms to org.eclipse.jetty.util.log.StdErrLog
2020-03-02 15:05:36.558:WARN:oejx.XmlConfiguration:main: Ignored arg: <Arg name="threadpool"><Ref refid="threadPool"/></Arg>
2020-03-02 15:05:36.696:WARN::main: demo test-realm is deployed. DO NOT USE IN PRODUCTION!
2020-03-02 15:05:36.698:INFO:oejs.Server:main: jetty-9.4.28-SNAPSHOT; built: 2020-03-02T18:07:43.942Z; git: f2a4c6b6150938c03022f29f3fa25bed5b7451f3; jvm 11.0.6+10
@joakime joakime self-assigned this Mar 2, 2020
@joakime joakime added the Bug For general bugs on Jetty side label Mar 2, 2020
@joakime
Copy link
Contributor Author

joakime commented Mar 2, 2020

This is ultimately a bad warning, the argument isn't being ignored, and is being used properly.

It's just a later check for <Arg> is incorrectly generating a WARN level message when it shouldn't.

joakime added a commit that referenced this issue Mar 2, 2020
@joakime
Issue #4631 - Fixing XML comment that was accidentally reformatted
b839ce6 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 2, 2020
@joakime
Issue #4631 - Warning about skipping of <Arg> nodes is in wrong place…
cfdffd1 
… for <Configure>

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Mar 2, 2020 that will close this issue
Issue #4631 - Warning about skipping of <Arg> nodes is in wrong place for <Configure> #4632
Merged
@joakime joakime mentioned this issue Mar 2, 2020
Closed
joakime added a commit that referenced this issue Mar 2, 2020
@joakime
Issue #4631 - Improving testcase
89f2cad 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2020
@joakime
Issue #4631 - Removing test classes
3ee3246 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2020
@joakime
Issue #4631 - Cleaning up configure with index per PR review
da7e8ed 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2020
@joakime
Issue #4631 - More named arg test cases
69fa180 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2020
@joakime
Issue #4631 - Add testConfiguredWithNamedArgNotFirst
cc80ebe 
+ new testcase where <Arg> is needed, but is not the first node

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw added a commit that referenced this issue Mar 10, 2020
@joakime @gregw
Issue #4631 - Warning about skipping of <Arg> nodes is in wrong place…
965483e 
… for <Configure> (#4632)

* Issue #4631 - Fixing XML comment that was accidentally reformatted

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4631 - Warning about skipping of <Arg> nodes is in wrong place for <Configure>

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4631 - Improving testcase

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4631 - Removing test classes

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4631 - Cleaning up configure with index per PR review

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4631 - More named arg test cases

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4631 - Add testConfiguredWithNamedArgNotFirst

+ new testcase where <Arg> is needed, but is not the first node

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Cleanup configuration index usage

Signed-off-by: Greg Wilkins <gregw@webtide.com>

Co-authored-by: Greg Wilkins <gregw@webtide.com>
@joakime joakime mentioned this issue Mar 10, 2020
Closed
@sbordet
Copy link
Contributor

sbordet commented Mar 31, 2020

Fixed by #4632.

@sbordet sbordet closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
2 participants
@joakime @sbordet