VERSION.TXT is missing some issues/PRs

[gregw]

Jetty version(s)
all

Description

The VERSION.TXT file is not being correctly generated. For example the recent 12.0.13 build was generated with:

jetty-12.0.13 - 03 September 2024
 + 3184 Make LifeCycle implement AutoCloseable
 + 3553 Support sslSession() in Jetty Client
 + 6514 How to warm up SslConnection
 + 9121 Jetty 12 - Flaky
   BlockedWritesWithSmallThreadPoolTest.testServerThreadsBlockedInWrites()
 + 11322 Change jetty-nosql MongoDB dependency from unmaintained
   mongo-java-driver to mongodb-driver-sync
 + 11408 Jetty start module property values with ${expr} are not being expanded
 + 11434 resolve differences in EE9/EE10/Core AliasCheckerSymlinkTests
 + 11822 h2 server responses exceeding SETTINGS_MAX_HEADER_LIST_SIZE do not
   result in RST_STREAM or GOAWAY
 + 11926 File upload puzzle
 + 12063 Introduce Jetty module for HTTP/2 client dependencies
 + 12094 Possible regression in ContextFactory.getObjectInstance() between
   Jetty 11.0.22 and 12.0.11
 + 12104 Error handling on ee9 / ee8 with HTTP/1.0 can result in an empty
   `Connection: ` response header.
 + 12120 Introduce properties for cipher suites
 + 12122 NPE in HttpReceiver.responseContentAvailable()
 + 12124 JSP temp directory regression, possibly due to fix for #12044
 + 12128 How do I configure embedded Jetty to serve webjars?
 + 12154 Is it possible to define max number of virtual threads when
   VirtualThreadsExecutor is enabled, i.e. max number of http requests being
   handled in the same time?
 + 12158 Jetty12 migration help
 + 12163 HttpConfiguration dump is missing entries
 + 12171 QoSHandler does not resume on a virtual thread
 + 12173 Jetty Maven Plugin - jetty:run does not work with pom type
   dependencies
 + 12175 `SslContextFactory` is hardcoded to use `Password`.
 + 12185 QosHandler suspend queue limit
 + 12207 Jetty Maven Plugin 12.x no longer configures `DefaultHandler`
 + 12212 ShutdownOutput for non-persistent HTTP/1 connections

But this is missing several issues and/or PRs that were in the project:

• Issue Change jetty-nosql MongoDB dependency from unmaintained mongo-java-driver to mongodb-driver-sync #11322 fixed by Issue #11322 Upgrade to mongodb-driver-sync 5.x #11681
• Issue Cannot invoke "org.eclipse.jetty.client.transport.HttpExchange.getRequest()" because "exchange" is null #11841 fixed by Improved handling of 100 Continue #12113
• etc.

The project has 71 issues and PR in the Done column, so assuming an issue and PR for each, that should be at least 35 entries in the VERSION.TXT, but there are only 25. So we are missing at least 10 entries (perhaps 20 if they were PRs only).

[gregw]

I'm not sure how far back this goes, so perhaps we need to regenerate all the release since 12.0.0?

[olamy]

Yup. I'm already looking at it.
The issue is happening for PRs without issues associated with it.
And this is affecting both VERSION.TXT and GitHub releases as well.
I have a fix that is almost ready for GH releases.
The idea I have in mind is to unify both generators into a single piece of code, and so have the exact same content generated.

[joakime]

The idea I have in mind is to unify both generators into a single piece of code, and so have the exact same content generated.

Lets chat, this is something that's been on my mind as well.
Also having 1 pass through the github API would be swell for generating the 3 things we need (VERSION.txt, tag text, and changelog markdown for releases)

[gregw]

@olamy I think it is more than just PRs without issues, as the examples listed above are PRs with issues.

[olamy]

@gregw sorry I'm referring the code we have for this :). the code is mixing commits and PRs. As we still have direct commits without using PRs so the code must parse commits and PRs to generate changelog.

[olamy]

@gregw those one were not in changelog #12182 #12176 #12098
no issue and no label attached :(

[olamy]

missing entries fixed with webtide/webtide-release-tools#3

It needs to be used for VERSION.TXT as well

[olamy]

some work done here https://github.com/webtide/webtide-release-tools
but not released yet.