Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathMappingsHandler exposes PathSpec and Context based on PathSpec #11494

Closed
joakime opened this issue Mar 7, 2024 · 1 comment · Fixed by #12738
Closed

PathMappingsHandler exposes PathSpec and Context based on PathSpec #11494

joakime opened this issue Mar 7, 2024 · 1 comment · Fixed by #12738
Assignees

Comments

@joakime
Copy link
Contributor

joakime commented Mar 7, 2024

Jetty version(s)
12.0.7

Enhancement Description
The existing PathMappingsHandler does not record the matched PathSpec that lead to the decision to call the specific handler.

I propose we add the matched PathSpec to the Request attributes before calling the matched Handler.

This has 2 benefits.

  1. The PathSpec details (like regex matched groupings, and uri-template variables / path-params, path-info, etc) can be obtained.
  2. The Request.getPathInContext(Request) can participate in the smart resolution of path-in-context from the matched PathSpec (as a primary source if a ContextHandler is not present?)
joakime added a commit that referenced this issue Mar 7, 2024
@joakime joakime changed the title PathMappingsHandler records matched PathSpec in Request Attributes PathMappingsHandler exposes PathSpec and Context based on PathSpec Mar 7, 2024
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.8 - FROZEN Mar 7, 2024
@joakime joakime self-assigned this Mar 7, 2024
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.9 - FROZEN Mar 27, 2024
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.10 (FROZEN) Apr 26, 2024
@joakime joakime moved this to 🏗 In progress in 🧊 Jetty 12.0.12 - FROZEN Jun 25, 2024
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.13 - FROZEN Jul 24, 2024
@olamy olamy moved this to 🏗 In progress in Jetty 12.0.14 Sep 2, 2024
@joakime joakime removed this from Jetty 12.0.14 Sep 25, 2024
joakime added a commit that referenced this issue Jan 27, 2025
joakime added a commit that referenced this issue Jan 27, 2025
… on PathSpec. (#12738)

* Issue #11494 - PathMappingsHandler exposes PathSpec and Context based on PathSpec.
@joakime
Copy link
Contributor Author

joakime commented Jan 27, 2025

Completed in PR #12738

@joakime joakime closed this as completed Jan 27, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.1.0 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment