Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test ServletTest.testSimpleIdleRead #10945

Closed
lorban opened this issue Nov 29, 2023 · 1 comment · Fixed by #11063
Closed

Flaky test ServletTest.testSimpleIdleRead #10945

lorban opened this issue Nov 29, 2023 · 1 comment · Fixed by #11063
Assignees
@sbordet
Labels
Bug For general bugs on Jetty side flaky-test
Milestone
12.0.x

Comments

@lorban
Copy link
Contributor

lorban commented Nov 29, 2023

Jetty version(s)
12.0.x

Jetty Environment
ee10

Description
org.eclipse.jetty.ee10.servlet.ServletTest.testSimpleIdleRead sometimes fails with:

Expected: a string containing " 200 OK"
     but: was "HTTP/1.1 500 Server Error
Server: Jetty(12.0.4-SNAPSHOT)
Date: Wed, 29 Nov 2023 08:39:37 GMT
Connection: close
Cache-Control: must-revalidate,no-cache,no-store
Content-Type: text/html;charset=iso-8859-1
Content-Length: 915

<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 500 java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 250/250 ms</title>
</head>
<body>
<h2>HTTP ERROR 500 java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 250/250 ms</h2>
<table>
<tr><th>URI:</th><td>http://local/ctx/post</td></tr>
<tr><th>STATUS:</th><td>500</td></tr>
<tr><th>MESSAGE:</th><td>java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 250/250 ms</td></tr>
<tr><th>CAUSED BY:</th><td>java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 250/250 ms</td></tr>
<tr><th>CAUSED BY:</th><td>java.util.concurrent.TimeoutException: Idle timeout expired: 250/250 ms</td></tr>
</table>
<hr/><a href="https://eclipse.org/jetty">Powered by Jetty:// 12.0.4-SNAPSHOT</a><hr/>

</body>
</html>
"

When it fails, the console contains this:

Running org.eclipse.jetty.ee10.servlet.AsyncListenerTest.testStartAsyncOnTimeoutThrow()
2023-11-29 08:39:37.384:INFO :oejs.Server:ForkJoinPool-1-worker-3: jetty-12.0.4-SNAPSHOT; built: 2023-11-29T08:20:31.218Z; git: d166056f18d81f5420f51612dc51dd3aa9118bf0; jvm 21+35-LTS
2023-11-29 08:39:37.385:INFO :oejsh.ContextHandler:ForkJoinPool-1-worker-3: Started oeje10s.ServletContextHandler@ab8f565{ROOT,/,b=null,a=AVAILABLE,h=oeje10s.ServletHandler@75b17f76{STARTED}}
2023-11-29 08:39:37.385:INFO :oejes.ServletContextHandler:ForkJoinPool-1-worker-3: Started oeje10s.ServletContextHandler@ab8f565{ROOT,/,b=null,a=AVAILABLE,h=oeje10s.ServletHandler@75b17f76{STARTED}}
2023-11-29 08:39:37.385:INFO :oejs.AbstractConnector:ForkJoinPool-1-worker-3: Started LocalConnector@264a250c{HTTP/1.1, (http/1.1)}
2023-11-29 08:39:37.385:INFO :oejs.Server:ForkJoinPool-1-worker-3: Started oejs.Server@51f146c8{STARTING}[12.0.4-SNAPSHOT,sto=0] @3001ms
2023-11-29 08:39:37.489:WARN :oejes.ServletChannel:ForkJoinPool-1-worker-1: handleException /ctx/post java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 250/250 ms
2023-11-29 08:39:37.493:WARN :oejsi.HttpConnection:ForkJoinPool-1-worker-1: Read pending org.eclipse.jetty.server.internal.HttpConnection$HttpStreamOverHTTP1@2befed66 LocalEndPoint@31002013[{l=/0.0.0.0:0,r=/0.0.0.0:0,OPEN,fill=FI,flush=-,to=0/250}]->[HttpConnection@632229[p=HttpParser{s=CONTENT,0 of 10},g=HttpGenerator@37f1bec0{s=END}]=>HttpChannelState@6321e185{handling=null, handled=true, send=LAST_COMPLETE, completed=true, request=POST@91166b4a http://local/ctx/post HTTP/1.1}][q=0,q[0]=null,o=HeapByteBuffer@258d4d71[p=0,l=1147,c=2396,r=1147]={<<<HTTP/1.1 500 Server Error...<hr/>\n\n</body>\n</html>\n>>>\x00\x00\x00\x00\x00\x00\x00\x00\x00...\x00\x00\x00\x00\x00\x00\x00}]
2023-11-29 08:39:37.503:INFO :oejs.Server:ForkJoinPool-1-worker-1: Stopped oejs.Server@3523a19b{STOPPING}[12.0.4-SNAPSHOT,sto=0]
2023-11-29 08:39:37.503:INFO :oejs.AbstractConnector:ForkJoinPool-1-worker-1: Stopped LocalConnector@4dbe32{HTTP/1.1, (http/1.1)}
2023-11-29 08:39:37.503:INFO :oejes.ServletContextHandler:ForkJoinPool-1-worker-1: Stopped oeje10s.ServletContextHandler@607f6d76{/ctx,/ctx,b=null,a=AVAILABLE,h=oeje10s.ServletHandler@7377b92e{STOPPED}}

See: https://jenkins.webtide.net/job/jetty.project/job/jetty-12.0.x/1716/testReport/junit/org.eclipse.jetty.ee10.servlet/ServletTest/Parallel_Stage___Build___Test___JDK21___testSimpleIdleRead/
@lorban lorban added Bug For general bugs on Jetty side flaky-test labels Nov 29, 2023
@lorban lorban added this to the 12.0.x milestone Nov 29, 2023
@sbordet sbordet assigned sbordet and unassigned lorban Dec 14, 2023
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.5 - FROZEN Dec 14, 2023
sbordet added a commit that referenced this issue Dec 14, 2023
@sbordet
Fixes #10945 - Flaky test ServletTest.testSimpleIdleRead
b7181f3 
Increased idle timeout durations, as 250ms is too short for CI.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Dec 14, 2023 that will close this issue
Fixes #10945 - Flaky test ServletTest.testSimpleIdleRead #11063
Merged
sbordet added a commit that referenced this issue Dec 14, 2023
@sbordet
Fixes #10945 - Flaky test ServletTest.testSimpleIdleRead (#11063)
3681d77 
Increased idle timeout durations, as 250ms is too short for CI, in both ee9 and ee10.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet
Copy link
Contributor

sbordet commented Dec 14, 2023

Fixed by #11063.

@sbordet sbordet closed this as completed Dec 14, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.5 - FROZEN Dec 14, 2023
@sbordet sbordet mentioned this issue Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Bug For general bugs on Jetty side flaky-test
Projects
No open projects
Jetty 12.0.5 - FROZEN
Status: ✅ Done
Milestone
12.0.x
Development

Successfully merging a pull request may close this issue.

Fixes #10945 - Flaky test ServletTest.testSimpleIdleRead jetty/jetty.project
2 participants
@sbordet @lorban