Skip to content

Commit

Permalink
Issue #4996 Fix LOG.info statements
Browse files Browse the repository at this point in the history 
Signed-off-by: Jan Bartel <janb@webtide.com>
  • Loading branch information
@janbartel
janbartel committed Aug 18, 2020
1 parent 6fd67f3 commit a4f5ec4
Show file tree
Hide file tree
Showing 19 changed files with 59 additions and 59 deletions.
2 changes: 1 addition & 1 deletion jetty-client/src/main/java/org/eclipse/jetty/client/LeakTrackingConnectionPool.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,6 @@ protected void released(Connection connection)

protected void leaked(LeakDetector.LeakInfo leakInfo)
{
LOG.info("Connection " + leakInfo.getResourceDescription() + " leaked at:", leakInfo.getStackFrames());
LOG.info("Connection {} leaked at:", leakInfo.getResourceDescription(), leakInfo.getStackFrames());
}
}
14 changes: 7 additions & 7 deletions jetty-client/src/main/java/org/eclipse/jetty/client/RequestNotifier.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private void notifyQueued(Request.QueuedListener listener, Request request)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand Down Expand Up @@ -92,7 +92,7 @@ private void notifyBegin(Request.BeginListener listener, Request request)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand Down Expand Up @@ -122,7 +122,7 @@ private void notifyHeaders(Request.HeadersListener listener, Request request)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand Down Expand Up @@ -152,7 +152,7 @@ private void notifyCommit(Request.CommitListener listener, Request request)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand Down Expand Up @@ -194,7 +194,7 @@ private void notifyContent(Request.ContentListener listener, Request request, By
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand Down Expand Up @@ -224,7 +224,7 @@ private void notifySuccess(Request.SuccessListener listener, Request request)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand Down Expand Up @@ -254,7 +254,7 @@ private void notifyFailure(Request.FailureListener listener, Request request, Th
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}
}
16 changes: 8 additions & 8 deletions jetty-client/src/main/java/org/eclipse/jetty/client/ResponseNotifier.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ private void notifyBegin(Response.BeginListener listener, Response response)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand All @@ -79,7 +79,7 @@ private boolean notifyHeader(Response.HeaderListener listener, Response response
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
return false;
}
}
Expand All @@ -101,7 +101,7 @@ private void notifyHeaders(Response.HeadersListener listener, Response response)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand All @@ -121,7 +121,7 @@ private void notifyBeforeContent(Response.DemandedContentListener listener, Resp
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand Down Expand Up @@ -156,7 +156,7 @@ private void notifyContent(Response.DemandedContentListener listener, Response r
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand All @@ -177,7 +177,7 @@ private void notifySuccess(Response.SuccessListener listener, Response response)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand All @@ -198,7 +198,7 @@ private void notifyFailure(Response.FailureListener listener, Response response,
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand All @@ -219,7 +219,7 @@ private void notifyComplete(Response.CompleteListener listener, Result result)
}
catch (Throwable x)
{
LOG.info("Exception while notifying listener " + listener, x);
LOG.info("Exception while notifying listener {}", listener, x);
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...y-http2/http2-client/src/main/java/org/eclipse/jetty/http2/client/HTTP2ClientSession.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ private Stream.Listener notifyPush(IStream stream, IStream pushStream, PushPromi
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
return null;
}
}
Expand Down
16 changes: 8 additions & 8 deletions jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/HTTP2Session.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ protected Stream.Listener notifyNewStream(Stream stream, HeadersFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
return null;
}
}
Expand All @@ -1178,7 +1178,7 @@ protected void notifySettings(Session session, SettingsFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -1190,7 +1190,7 @@ protected void notifyPing(Session session, PingFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -1202,7 +1202,7 @@ protected void notifyReset(Session session, ResetFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -1214,7 +1214,7 @@ protected void notifyClose(Session session, GoAwayFrame frame, Callback callback
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -1226,7 +1226,7 @@ protected boolean notifyIdleTimeout(Session session)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
return true;
}
}
Expand All @@ -1239,7 +1239,7 @@ protected void notifyFailure(Session session, Throwable failure, Callback callba
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -1254,7 +1254,7 @@ protected void notifyHeaders(IStream stream, HeadersFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand Down
14 changes: 7 additions & 7 deletions jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/HTTP2Stream.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ private void notifyNewStream(Stream stream)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}
}
Expand All @@ -724,7 +724,7 @@ private void notifyBeforeData(Stream stream)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}
else
Expand All @@ -744,7 +744,7 @@ private void notifyDataDemanded(Stream stream, DataFrame frame, Callback callbac
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
callback.failed(x);
}
}
Expand All @@ -766,7 +766,7 @@ private void notifyReset(Stream stream, ResetFrame frame, Callback callback)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
callback.failed(x);
}
}
Expand All @@ -787,7 +787,7 @@ private boolean notifyIdleTimeout(Stream stream, Throwable failure)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
return true;
}
}
Expand All @@ -803,7 +803,7 @@ private void notifyFailure(Stream stream, FailureFrame frame, Callback callback)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
callback.failed(x);
}
}
Expand All @@ -824,7 +824,7 @@ private void notifyClosed(Stream stream)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand Down
22 changes: 11 additions & 11 deletions jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/parser/BodyParser.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ protected void notifyData(DataFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -121,7 +121,7 @@ protected void notifyHeaders(HeadersFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -133,7 +133,7 @@ protected void notifyPriority(PriorityFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -145,7 +145,7 @@ protected void notifyReset(ResetFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -157,7 +157,7 @@ protected void notifySettings(SettingsFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -169,7 +169,7 @@ protected void notifyPushPromise(PushPromiseFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -181,7 +181,7 @@ protected void notifyPing(PingFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -193,7 +193,7 @@ protected void notifyGoAway(GoAwayFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -205,7 +205,7 @@ protected void notifyWindowUpdate(WindowUpdateFrame frame)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -224,7 +224,7 @@ private void notifyConnectionFailure(int error, String reason)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand All @@ -242,7 +242,7 @@ private void notifyStreamFailure(int streamId, int error, String reason)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand Down
2 changes: 1 addition & 1 deletion jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/parser/Parser.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ protected void notifyConnectionFailure(int error, String reason)
}
catch (Throwable x)
{
LOG.info("Failure while notifying listener " + listener, x);
LOG.info("Failure while notifying listener {}", listener, x);
}
}

Expand Down
Loading

0 comments on commit a4f5ec4

Please sign in to comment.