Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix unseal-period CLI option #15

Merged
merged 1 commit into from
Nov 17, 2018

Conversation

sheldonkwok
Copy link
Contributor

@sheldonkwok sheldonkwok commented Aug 7, 2018

Right now you can configure the `unseal-period` but it's not being used. This utilizes it in the sleep. 

@sheldonkwok
Copy link
Contributor Author

/assign @munnerz

@sheldonkwok sheldonkwok changed the title Utilize cfgUnsealPeriod to sleep Fix unseal-period CLI option Aug 17, 2018
@sheldonkwok
Copy link
Contributor Author

@simonswine any chance someone else can take a look? It's just a one line fix on a CLI option. Thanks!
cc @munnerz

@simonswine
Copy link
Contributor

/unassign @munnerz
/assign
/ok-to-test

@simonswine
Copy link
Contributor

/assign @sheldonkwok
/unassign

Thanks for your contribution, thanks for fixing this oversight.
Can you add the DCO sign off to your commit please (yay legals)

And reassign to me once that is done

Signed-off-by: Sheldon Kwok <sheldon@secondspectrum.com>
@sheldonkwok
Copy link
Contributor Author

Done, thanks!
/assign @simonswine

@sheldonkwok
Copy link
Contributor Author

@simonswine any update on this?

@fladrif
Copy link

fladrif commented Nov 17, 2018

This would be helpful for me as well, what's the status on this PR?

@JoshVanL
Copy link
Contributor

/lgtm

@JoshVanL
Copy link
Contributor

@simonswine assume ok to approve?

@munnerz
Copy link
Contributor

munnerz commented Nov 17, 2018

/approve

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit dc14d40 into jetstack:master Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants