Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Upgrade fluentbit to 1.0.4 #725

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Upgrade fluentbit to 1.0.4 #725

merged 1 commit into from
Feb 11, 2019

Conversation

simonswine
Copy link
Contributor

Signed-off-by: Christian Simon simon@swine.de

Upgrade fluentbit to 1.0.4

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/puppet Indicates a PR is affecting Puppet manifests labels Feb 7, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2019
@simonswine simonswine self-assigned this Feb 7, 2019
@simonswine
Copy link
Contributor Author

Over to you

/assign @JoshVanL

@simonswine simonswine removed their assignment Feb 7, 2019
@JoshVanL
Copy link
Contributor

JoshVanL commented Feb 8, 2019

fluent-bit pods failing for me

Warning Failed 2m31s (x5 over 3m58s) kubelet, ip-10-99-48-239.eu-west-1.compute.internal Error: failed to start container "fluent-bit": Error response from daemon: oci runtime error: container_linux.go:247: starting container process caused "exec: \"/bin/sh\": stat /bin/sh: no such file or directory"

@JoshVanL
Copy link
Contributor

JoshVanL commented Feb 8, 2019

/unasign
/assign @simonswine

@JoshVanL
Copy link
Contributor

JoshVanL commented Feb 8, 2019

/unassign

@simonswine
Upgrade fluentbit to 1.0.4
e08038e 
Fluent-bit changed the docker image from 1.0 and ships without busybox.
These ammendemnts make sure we still functinn properly.

Signed-off-by: Christian Simon <simon@swine.de>
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2019
@simonswine
Copy link
Contributor Author

Thanks good catch, was not straightforward to fix they removed busybox from their image

/assign @JoshVanL
/unassign

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Feb 8, 2019
@JoshVanL
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@jetstack-bot jetstack-bot merged commit 88540f0 into jetstack:master Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dippynark dippynark Awaiting requested review from dippynark

Assignees

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/puppet Indicates a PR is affecting Puppet manifests dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonswine @jetstack-bot @JoshVanL