-
Notifications
You must be signed in to change notification settings - Fork 43
Disable cobra flags after kubectl sub-command #621
Disable cobra flags after kubectl sub-command #621
Conversation
I think a PR should remove the workaround code in here: https://github.com/jetstack/tarmak/blob/master/cmd/tarmak/cmd/root.go#L46 And also apply for the SSH command. A important test is if all arguments before kubectl/ssh are still parsed accordingly by tarmak |
/unassign @simonswine |
619ff9a
to
87bcd81
Compare
/unassign |
87bcd81
to
611bc8e
Compare
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
611bc8e
to
1b2ff52
Compare
Nice work. Esp the testing @JoshVanL Wasn't able to break it. |
/lgtm |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This fixes a problem whereby we were not passing flags or
--
to kubectl correctly as they were being interpreted by croba, e.g.tarmak kubectl exec -it shell-demo -- /bin/bash
This sets all arguments after
kubectl
to be passed tokubectl
.fixes #477
/assign @simonswine