Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lockfile] Fix tidy for non-versioned packages #2313

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

mikeland73
Copy link
Contributor

@mikeland73 mikeland73 commented Sep 30, 2024

Summary

Fixes issue introduced in #2277

This comment explains it pretty well: https://github.com/jetify-com/devbox/pull/2277/files#r1767085866

except:

I think this doesn't matter in practice, because we always append @latest during devbox add .

This is not 100% true. In the very small number of packages that are not in nixhub but are valid attribute paths, (e.g. stdenv.cc.cc.lib) we store the key in the lockfile without @latest :(. The key missmatch caused lockfile.Tidy to remove entries.

My bad for making the suggestion that lead to this, this was really subtle difference.

How was it tested?

Added stdenv.cc.cc.lib on devbox.json linux only, installed on linux and copied over lockfile to macos. Did devbox install and ensured lockfile was not modified.

Copy link
Collaborator

@savil savil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot! I did not consider that scenario. This is unfortunately a regression that may bite some folks in terms of updating their lockfiles cc @Lagoja

thank you for fixing it

@mikeland73 mikeland73 merged commit 0ff66c1 into main Oct 1, 2024
29 checks passed
@mikeland73 mikeland73 deleted the landau/fix-tidy branch October 1, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants