[lockfile] Fix tidy for non-versioned packages #2313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue introduced in #2277
This comment explains it pretty well: https://github.com/jetify-com/devbox/pull/2277/files#r1767085866
except:
This is not 100% true. In the very small number of packages that are not in nixhub but are valid attribute paths, (e.g.
stdenv.cc.cc.lib
) we store the key in the lockfile without@latest
:(. The key missmatch caused lockfile.Tidy to remove entries.My bad for making the suggestion that lead to this, this was really subtle difference.
How was it tested?
Added
stdenv.cc.cc.lib
on devbox.json linux only, installed on linux and copied over lockfile to macos. Diddevbox install
and ensured lockfile was not modified.