[telemetry] Don't log user errors #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcurtis
approved these changes
Sep 27, 2024
mikeland73
added a commit
that referenced
this pull request
Oct 4, 2024
## Summary Fixes bug introduced in #2305 ## How was it tested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're running out of Sentry events and it looks like the culprit is devbox overlogging, including a lot of user errors that should not be logged.
This PR #844 removed code that avoided logging user errors. I think this was a bug? If programmer wants a user error to be logged, they should use
WithLoggedUserMessageinstead.How was it tested?
Untested