[ux] Improve refresh messaging #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jun 26, 2024
internal/devbox/packages.go
Outdated
| @@ -37,6 +37,8 @@ import ( | |||
| "go.jetpack.io/devbox/internal/ux" | |||
| ) | |||
|
|
|||
| var StateOutOfDateMessage = "Your devbox environment may be out of date. Run %s to update it.\n" | |||
| @@ -285,9 +287,10 @@ func (d *Devbox) ensureStateIsUpToDate(ctx context.Context, mode installMode) er | |||
| // be out of date after the user installs something. If have direnv active | |||
| // it should reload automatically so we don't need to refresh. | |||
| if d.IsEnvEnabled() && !upToDate && !d.IsDirenvActive() { | |||
| ux.Fwarning( | |||
| ux.FHidableWarning( | |||
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few improvements:
refresh-globaleven if alias is not set (since it will likely be set by the end of the command).How was it tested?