Fix macos caching issue #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucilleH
force-pushed
the
lucille--macos-cache
branch
6 times, most recently
from
c45d652 to
38a9442
Compare
LucilleH
force-pushed
the
lucille--macos-cache
branch
6 times, most recently
from
ddea841 to
01f4e1c
Compare
LucilleH
force-pushed
the
lucille--macos-cache
branch
12 times, most recently
from
f852f26 to
a7d0997
Compare
LucilleH
force-pushed
the
lucille--macos-cache
branch
from
a7d0997 to
efe9b42
Compare
mikeland73
approved these changes
Sep 19, 2023
|
cc: @alex35mil |
LucilleH
force-pushed
the
lucille--macos-cache
branch
from
1bf1ffa to
ea9269c
Compare
|
Thanks! Though I reverted the addition of the Devbox to CI for now as apparently I can't use it for Windows builds yet. |
savil
reviewed
Sep 19, 2023
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ~/.cache |
There was a problem hiding this comment.
should we scope this to ~/.cache/nix and/or ~/.cache/devbox ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
macOS caching is broken. This PR fixes it. This is related to
gtarnot havingsudopermission, but/nix/storerequires sudo. There are many many related issues out there. eg. actions/cache#749I also switched to using DeterminateSystems nix installer. However, I noticed that even though cache is successfully restored in the latest round of CICD, we are still fetching the binaries from remote? (at least based on the log lines) Why is that?
I suspect that I'm missing some sqlite data in the cached files. cc @savil @gcurtis if any of you have insights into this.
EDIT: SOLVED. Added xdg paths in the cache and it reduces the time by half. 🎉 🎉 🎉
closes #13