Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Annotation option #185

Merged
merged 8 commits into from
Nov 8, 2018
Merged

Conversation

remijouannet
Copy link
Contributor

Hello

A quick and easy patch to add an Annotation option for iso and cmd builder to edit the "note" part of the VM

@mkuzmin mkuzmin merged commit e929b19 into jetbrains-infra:master Nov 8, 2018
@remijouannet remijouannet deleted the annotation branch November 15, 2018 23:59
pragmaspark pushed a commit that referenced this pull request Nov 22, 2018
@jcoconnor
Copy link
Contributor

👏 Tx

@tigerhawk6
Copy link

Is this working for anyone else? I've tested by building from master and from v2.1 release.

image

@mkuzmin
Copy link
Contributor

mkuzmin commented Dec 16, 2018

not released yet, but should work in current build

@tigerhawk6
Copy link

I did a fresh build today and got the same error.

@mkuzmin
Copy link
Contributor

mkuzmin commented Dec 18, 2018

I have no idea. Get binaries from TeamCity, and check them

@tigerhawk6
Copy link

That version works fine. Trying to figure out why my build from master isn't. Weird. Anyway, thanks for the help.

@jcoconnor
Copy link
Contributor

I've just tried build 170 and its still failing with the following error:

10:34:16 ==> vcenter-iso: Uploading created floppy image
10:34:16 ==> vcenter-iso: Destroying VM...
10:34:17 Build 'vcenter-iso' errored: host '' not found
10:34:17 
10:34:17 ==> Some builds didn't complete successfully and had errors:
10:34:17 --> vcenter-iso: host '' not found

@mkuzmin
Copy link
Contributor

mkuzmin commented Dec 20, 2018

Check #183, this is related to clusters

@jcoconnor
Copy link
Contributor

So - I tried filling in a fixed value for the host parameter and build worked fine - Notes field was filled.
Just saw your new comment - is a build available with both this and #183 addressed - happy to run thru test (although will be on PTO for about 2 during holiday period).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants