Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not highlight matched asymmetricMatcher in diffs #9257
Do not highlight matched asymmetricMatcher in diffs #9257
Changes from 44 commits
586b17a
ec68d66
4f7c31a
e69b816
727d5e5
2c88e99
3885f56
7a04cb0
48ab232
69fbc5d
149783b
883f4cd
a6632ed
4f5c1a9
29154cd
e99e985
7aa6f27
b148c0f
fd6443e
ba5d7ec
34c18dc
e0a6288
c5361b4
c90a4ed
d7c9a55
b438d6d
65bd0cc
61f2c9f
4c0f959
03e00c3
9a81ffc
67c443e
263f9a7
d5863fa
8f5321a
83ddb57
4d4b7ce
d9dd2c4
d4c2f5e
1db1b73
739d835
3e200ce
829ef89
684b8ff
0a26b71
0f441f4
c63cc72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can all these
any
s beunknown
s?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If change
any
tounknown
, it will do a lot task for type converting.For example:
I think it make code a little bit ugly, although is suitable for typescript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
Object.entries
on Mozilla Developer NetworkTherefore, you might need to add the following iteration for enumerable symbol-keyed properties:
The
forEach
method forMap
andSet
do not have this problem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the diff snapshots in
matchers.test.ts.snap
cover the case of symbol keys :(There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add some symbol keys test cases, and make them work.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WeiAnAn For your information, the current target for Jest 25 is Tuesday January 21, so if this rare edge case will slow you down too much, please leave it for a follow-up pull request. The copy function is the important thing.