Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make changedFiles option optional in shouldInstrument #9197

Merged
merged 3 commits into from
Nov 17, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 17, 2019

Summary

Extracted from #9192

Test plan

Green CI

@@ -58,7 +58,7 @@ export default function shouldInstrument(
if (
// still cover if `only` is specified
!options.collectCoverageOnlyFrom &&
options.collectCoverageFrom &&
options.collectCoverageFrom.length &&
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorta breaking? Only for people calling this manually though, and they'd get a type error. Fine for Jest 25.

Also a bug fix if you forgot to send it in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, Jest didn't always pass it, so that's nice :P Looking forward to making normalize in jest-config actually be type safe...

@SimenB SimenB force-pushed the should-instrument-type-tweak branch from 5f9e417 to 6e7347e Compare November 17, 2019 19:12
@codecov-io
Copy link

Codecov Report

Merging #9197 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9197      +/-   ##
==========================================
+ Coverage   64.83%   64.85%   +0.01%     
==========================================
  Files         279      279              
  Lines       11742    11744       +2     
  Branches     2887     2888       +1     
==========================================
+ Hits         7613     7616       +3     
+ Misses       3511     3510       -1     
  Partials      618      618
Impacted Files Coverage Δ
packages/jest-transform/src/shouldInstrument.ts 88.23% <ø> (ø) ⬆️
packages/jest-runtime/src/index.ts 69.12% <100%> (+0.26%) ⬆️
packages/jest-config/src/normalize.ts 81.28% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b97d6...cfc6848. Read the comment docs.

@SimenB SimenB changed the title chore: make changedFiles option optional instead of |undefined in shouldInstrument chore: make changedFiles option optional in shouldInstrument Nov 17, 2019
@SimenB SimenB merged commit 4643178 into jestjs:master Nov 17, 2019
@SimenB SimenB deleted the should-instrument-type-tweak branch November 17, 2019 20:27
ayush000 added a commit to ayush000/jest that referenced this pull request Nov 21, 2019
* master:
  chore: upgrade to fsevents 2 (jestjs#9215)
  docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149)
  chore: bump to istanbul alphas (jestjs#9192)
  Fix typo in JestPlatform.md (jestjs#9212)
  jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203)
  fix(jest-types): tighten Config types and set more defaults (jestjs#9200)
  jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132)
  jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198)
  chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197)
  fix(pretty-format): correctly detect memo (jestjs#9196)
  chore: regenerate lockfiles in e2e tests (jestjs#9193)
  chore: bump handlebars
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants