Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import clearline rather than duplicating it #8875

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 26, 2019

Summary

Part of #8863 (which broke the cycle this change would have introduced), so no separate changelog.

Test plan

Green CI

@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #8875 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8875      +/-   ##
==========================================
+ Coverage   64.12%   64.13%   +0.01%     
==========================================
  Files         275      275              
  Lines       11629    11627       -2     
  Branches     2845     2844       -1     
==========================================
  Hits         7457     7457              
+ Misses       3545     3544       -1     
+ Partials      627      626       -1
Impacted Files Coverage Δ
packages/jest-console/src/CustomConsole.ts 77.08% <ø> (+3.08%) ⬆️
packages/jest-core/src/runJest.ts 56% <ø> (ø) ⬆️
packages/jest-util/src/clearLine.ts 0% <0%> (ø) ⬆️
packages/jest-util/src/preRunMessage.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6a8e8...2c2b507. Read the comment docs.

@SimenB SimenB merged commit 4e9ac72 into jestjs:master Aug 26, 2019
@SimenB SimenB deleted the import-clearline branch August 26, 2019 07:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants