Jest 25 #8862
Merged
Jest 25 #8862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: upgrade to micromatch v4 * fix anymatch namespace issue * use match instead of some * add explicit check for length 0 * more length boolean checks
scotthovestadt
approved these changes
Aug 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #8862 +/- ##
==========================================
- Coverage 63.87% 63.79% -0.08%
==========================================
Files 274 274
Lines 11627 11591 -36
Branches 2854 2842 -12
==========================================
- Hits 7427 7395 -32
+ Misses 3569 3566 -3
+ Partials 631 630 -1
Continue to review full report at Codecov.
|
thymikee
approved these changes
Aug 22, 2019
haoqunjiang
added a commit
to haoqunjiang/vue-cli
that referenced
this pull request
Sep 17, 2019
Jest has released version 25 under the `next` dist-tag: - https://www.npmjs.com/package/jest/v/25.0.0 - jestjs/jest#8862 See breaking changes at https://github.com/facebook/jest/blob/6c0a16ab2f88ea645c04880a5491b3a8c2dfc66b/CHANGELOG.md The maintainer promised no more user facing breaking changes planned jestjs/jest#8956 (comment) Considering Vue CLI does not bump the major version often, we need to use the latest possible version. Currently there will be warnings from ts-jest. Once this PR gets merged kulshekhar/ts-jest#1232 the warnings will be eliminated.
9 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure to use "rebase and merge" rather than squash merging this
For consumers, the only breaking changes should be dropped Node 6 and upgraded JSDOM. I think that's a nice major version, and we can land more of the planned breaking changes in Jest 26. Thoughts on that?
I can put together a small blog post as well.
Note that this branch is available as
jest@nextonnpm.Test plan
Green CI