Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-snapshot: Remove only the added newlines in multiline snapshots #8859

Merged
merged 5 commits into from
Aug 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- `[expect]` Display expectedDiff more carefully in toBeCloseTo ([#8389](https://github.com/facebook/jest/pull/8389))
- `[jest-fake-timers]` `getTimerCount` will not include cancelled immediates ([#8764](https://github.com/facebook/jest/pull/8764))
- `[jest-snapshot]` Remove only the added newlines in multiline snapshots ([#8859](https://github.com/facebook/jest/pull/8859))

### Chore & Maintenance

Expand Down
74 changes: 74 additions & 0 deletions packages/jest-snapshot/src/__tests__/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ import {
SNAPSHOT_GUIDE_LINK,
SNAPSHOT_VERSION,
SNAPSHOT_VERSION_WARNING,
addExtraLineBreaks,
deepMerge,
getSnapshotData,
keyToTestName,
removeExtraLineBreaks,
saveSnapshotFile,
serialize,
testNameToKey,
Expand Down Expand Up @@ -192,6 +194,78 @@ test('serialize handles \\r\\n', () => {
expect(serializedData).toBe('\n"<div>\n</div>"\n');
});

describe('ExtraLineBreaks', () => {
test('0 empty string', () => {
const expected = '';

const added = addExtraLineBreaks(expected);
const removed = removeExtraLineBreaks(added);

expect(added).toBe(expected);
expect(removed).toBe(expected);
});

test('1 line has double quote marks at edges', () => {
const expected = '" one line "';

const added = addExtraLineBreaks(expected);
const removed = removeExtraLineBreaks(added);

expect(added).toBe(expected);
expect(removed).toBe(expected);
});

test('1 line has spaces at edges', () => {
const expected = ' one line ';

const added = addExtraLineBreaks(expected);
const removed = removeExtraLineBreaks(added);

expect(added).toBe(expected);
expect(removed).toBe(expected);
});

test('2 lines both are blank', () => {
const expected = '\n';

const added = addExtraLineBreaks(expected);
const removed = removeExtraLineBreaks(added);

expect(added).toBe('\n' + expected + '\n');
expect(removed).toBe(expected);
});

test('2 lines have double quote marks at edges', () => {
const expected = '"\n"';

const added = addExtraLineBreaks(expected);
const removed = removeExtraLineBreaks(added);

expect(added).toBe('\n' + expected + '\n');
expect(removed).toBe(expected);
});

test('2 lines first is blank', () => {
const expected = '\nsecond line ';

const added = addExtraLineBreaks(expected);
const removed = removeExtraLineBreaks(added);

expect(added).toBe('\n' + expected + '\n');
expect(removed).toBe(expected);
});

test('2 lines last is blank', () => {
const expected = ' first line\n';

const added = addExtraLineBreaks(expected);
const removed = removeExtraLineBreaks(added);

expect(added).toBe('\n' + expected + '\n');
expect(removed).toBe(expected);
});
});

describe('DeepMerge with property matchers', () => {
const matcher = expect.any(String);

Expand Down
4 changes: 2 additions & 2 deletions packages/jest-snapshot/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,8 @@ const _toMatchSnapshot = ({
`${RECEIVED_COLOR('Received value')} ` +
`${actual}`;
} else {
expected = (expected || '').trim();
actual = (actual || '').trim();
expected = utils.removeExtraLineBreaks(expected || '');
actual = utils.removeExtraLineBreaks(actual || '');

// Assign to local variable because of declaration let expected:
// TypeScript thinks it could change before report function is called.
Expand Down
14 changes: 11 additions & 3 deletions packages/jest-snapshot/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,19 @@ export const getSnapshotData = (
return {data, dirty};
};

// Extra line breaks at the beginning and at the end of the snapshot are useful
// to make the content of the snapshot easier to read
const addExtraLineBreaks = (string: string): string =>
// Add extra line breaks at beginning and end of multiline snapshot
// to make the content easier to read.
export const addExtraLineBreaks = (string: string): string =>
string.includes('\n') ? `\n${string}\n` : string;

// Remove extra line breaks at beginning and end of multiline snapshot.
// Instead of trim, which can remove additional newlines or spaces
// at beginning or end of the content from a custom serializer.
export const removeExtraLineBreaks = (string: string): string =>
string.length > 2 && string.startsWith('\n') && string.endsWith('\n')
? string.slice(1, -1)
: string;

export const serialize = (data: string): string =>
addExtraLineBreaks(
normalizeNewlines(
Expand Down