Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception to clean-e2e for global-setup-node-modules #8174

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Mar 20, 2019

Summary

For e2e/global-setup-node-modules/node_modules/example/index.js see #8143 (comment)

Edited clean-e2e script:

  • Added -not \( -path ./e2e/global-setup-node-modules -prune \)
  • Edited -mindepth 1 because -mindepth 2 filtered out the exception

/cc @Volune

We give CHANGELOG.md a miss for small follow-up fix, true?

Test plan

yarn clean-all && yarn
git status
yarn test

EDIT: and to make sure that it doesn’t depend on full yarn install, I followed up with:

yarn clean-e2e
yarn jest

@codecov-io
Copy link

Codecov Report

Merging #8174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8174   +/-   ##
=======================================
  Coverage   62.33%   62.33%           
=======================================
  Files         265      265           
  Lines       10465    10465           
  Branches     2542     2543    +1     
=======================================
  Hits         6523     6523           
  Misses       3359     3359           
  Partials      583      583

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37a117...8182d9f. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Mar 20, 2019

We give CHANGELOG.md a miss for small follow-up fix, true?

True!

@SimenB SimenB merged commit 5b680db into jestjs:master Mar 20, 2019
@pedrottimark pedrottimark deleted the node-modules-exception branch March 20, 2019 19:20
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants