Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run yarn after new release #7715

Merged
merged 1 commit into from
Jan 26, 2019
Merged

chore: run yarn after new release #7715

merged 1 commit into from
Jan 26, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 26, 2019

Summary

Extracting the noisy parts of #7707 and #7714 into a separate PR

Test plan

Green CI, this doesn't really change anything. We might consider running yarn with --frozen-lockfile on ci?

@SimenB SimenB merged commit f2fb112 into jestjs:master Jan 26, 2019
@SimenB SimenB deleted the run-yarn branch January 26, 2019 09:03
@@ -2182,6 +2182,31 @@ babel-code-frame@6.26.0:
esutils "^2.0.2"
js-tokens "^3.0.2"

babel-core@^6.0.0, babel-core@^6.26.0:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lock is pulling in Jest 23 and Babel 6. Is that correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"correct" is relative 😛: #7707 (comment)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unfortunate!

@jeysal
Copy link
Contributor

jeysal commented Jan 26, 2019

+1 for --frozen-lockfile, it's what the Yarn docs recommend

@SimenB
Copy link
Member Author

SimenB commented Jan 26, 2019

#7717

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants