Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toStrictEqual considers array sparseness (resolves #7586) #7591

Merged
merged 4 commits into from
Jan 9, 2019

Conversation

marcfallows
Copy link
Contributor

Summary

Fixes the bug raised in #7586.

Test plan

Unit tests are included to cover the case.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@jeysal
Copy link
Contributor

jeysal commented Jan 8, 2019

Cool, thanks for the issue and swift fix! :)

@SimenB SimenB requested a review from thymikee January 9, 2019 08:01
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be super nice to add an example using arrays to the docs :)

@marcfallows
Copy link
Contributor Author

Would be super nice to add an example using arrays to the docs :)

I've added a line to the docs in 1c2d351. I felt a code example wasn't really necessary as it fit in quite nicely alongside the line above regarding keys.

@thymikee thymikee merged commit 055e31e into jestjs:master Jan 9, 2019
@thymikee
Copy link
Collaborator

thymikee commented Jan 9, 2019

Thank you so much @marcfallows!

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
…estjs#7591)

* fix: toStrictEqual considers array sparseness (resolves jestjs#7586)

* changelog

* review feedback

* line in docs
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants