Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: landing page redesign #7566

Merged
merged 52 commits into from
Jan 25, 2019
Merged

docs: landing page redesign #7566

merged 52 commits into from
Jan 25, 2019

Conversation

montogeek
Copy link
Contributor

@montogeek montogeek commented Dec 30, 2018

Summary

Implements new landing page as discussed in #7265

Test plan

Run website locally, make sure it looks as the design. Preview: https://deploy-preview-7566--jest-preview.netlify.com/

Dec 30 progress:

  • 70% of the homepage implemented using new design.

ToDo:

  • Cards section
  • Main information (white text over gray background)
  • Yellow bullet points
  • Philosophy

Notes:
Docusaurus fulfills its purpose, but its CSS architecture leaves much to be desired, making really hard to make some changes, also it doesn't support custom Navigation bar, only Footer, I am expressing these concerns because you will find some ugly CSS that could be completely avoided if Docusaurus was different.

@SimenB
Copy link
Member

SimenB commented Dec 30, 2018

So cool! It's deployed here: https://deploy-preview-7566--jest-preview.netlify.com/

Docusaurus fulfills its purpose, but its CSS architecture leaves much to be desired, making really hard to make some changes

Will be improved in the next version: https://docusaurus.io/blog/2018/09/11/Towards-Docusaurus-2#layout

Not sure if an alpha is published, or viable to use?

@SimenB SimenB requested a review from orta December 30, 2018 19:56
<MarkdownBlock>
<translate>
A lot of people! With
[8.5m](https://www.npmjs.com/package/jest) downloads in
Copy link
Member

@SimenB SimenB Dec 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way of keeping these numbers updated automatically?

Might be a cool docusaurus feature (showing stats from npm and github) - we already tell docusaurs what our package is named and what repo it's hosted at, /cc @endiliey

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that would be really useful

@montogeek
Copy link
Contributor Author

Do'h, I forgot to uncomment my progress :/

@montogeek
Copy link
Contributor Author

Will be improved in the next version: https://docusaurus.io/blog/2018/09/11/Towards-Docusaurus-2#layout

That's good to know, It is there any progress or proposition about how exactly it is going to be?

@orta
Copy link
Member

orta commented Dec 30, 2018

I think to one way to simplify the header CSS, is to make the custom nav CSS only affect the index page - then the rest of the pages can use the navigation bar etc. Which at least scopes the hacks to a single page.

@brainkim brainkim mentioned this pull request Dec 30, 2018
7 tasks
@orta
Copy link
Member

orta commented Dec 31, 2018

We have a working implementation of the cards in #7567 - so I've ticked that for you 👍

And I've asked @cpojer to try figure out the copy for the philosophy

@cpojer
Copy link
Member

cpojer commented Jan 2, 2019

I think Jest's philosophy hasn't changed much over the years:

  • Fast
  • Feature-rich
  • Easy to use out of the box but highly configurable
  • Approachable with familiar APIs
  • Extensible
  • Well documented
  • Fun!

How about:

Jest is a JavaScript testing framework designed to ensure correctness of any JavaScript codebase. It allows you to write tests with its approachable, familiar and feature-rich APIs that give you results quickly. Jest is extensively documented, requires little configuration and can be extended to match your requirements. Jest makes testing delightful.

?

@cpojer
Copy link
Member

cpojer commented Jan 3, 2019

The cards are fantastic. I have some thoughts on how I think it could lead to a better first impression:

  • Can we make the initial animation a bit faster? Like, let's turn one card around within ~1s of opening the page. Otherwise we make it seem like Jest is slow.
  • I'd like for at least 2 cards to be green at all times. It could be 2, 3 or 4 green cards, and at most 2 red cards. It doesn't give a good impression if the cards "fail" on the first visit to the website.

@brainkim
Copy link

brainkim commented Jan 3, 2019

@cpojer
f1c8e03

Can we make the initial animation a bit faster?

Done. I reduced the time for the first animation to 2.5 seconds. Any shorter and there’s significant jank on slower clients. Specifically, Firefox has trouble with the initial animation when assets are slow to load and I imagine this could be fixed by inlining the svg logos, but doing so is difficult because I'm doing everything in a dangerouslySetInnerHTML script tag.

I'd like for at least 2 cards to be green at all times.

Done. Don’t read the code too closely 🤪

@orta
Copy link
Member

orta commented Jan 21, 2019

Thanks for the reminder, fixed!

@cpojer
Copy link
Member

cpojer commented Jan 21, 2019

  • I think adding a subtle hover style for the top bar (opacity: 80% or something) and text-decoration: none for regular green links may be a good idea.
  • I'd add a full-stop . at the end of the sentence "Jest is a delightful JavaScript Testing Framework with a focus on simplicity".
  • Since the "JEST" logo in the top bar changed, it may be best to revert the change from my earlier recommendation of reducing font-size of the version number. I think it would look better now if the font-size was the same as the JEST text again.

Other than those minor things, I love it. Shipit!

@orta
Copy link
Member

orta commented Jan 21, 2019

OK, I've shipped all of those changes too 👍

@SimenB
Copy link
Member

SimenB commented Jan 21, 2019

(I still think it would be cool to land together with the blog post for Jest 24, feel free to ignore if you disagree, though)

@cpojer
Copy link
Member

cpojer commented Jan 21, 2019

Thanks for making those changes but seems like the green text doesn't have a hover style still. I agree with @SimenB it would be awesome to land together; and mention it in the blog post, but if you think we should do it separately I'm ok with that too.

One thing that @gaearon brought up was not re-running the full animation on subsequent reloads. I'm wondering if we could disable the animation to only play once in an hour or once in a day; and possibly speed it up on every re-visit of the site, indicating that the "test run" gets faster each time. I think that would be a cool gimmick using localStorage. What do you think?

@cpojer
Copy link
Member

cpojer commented Jan 21, 2019

One more on the headlines:

  • Excellent Exceptions -> "Great Exceptions"? (I get the pun but feel like it's overstating it a bit)
  • Mocking with ease -> "Easy Mocking"?

@SimenB SimenB mentioned this pull request Jan 21, 2019
@orta
Copy link
Member

orta commented Jan 21, 2019

Oops, missed the hover state - fixed.

not re-running the full animation on subsequent reloads

When I tested this site on folks at our Peer Labs all but one immediately re-watched the animation was by reloading the page. I think disabling it on the second time would end up making that a bit disappointing (or feel buggy).

So, I've made 2nd runs have half the base wait-time that the 1st run has 👍

@thymikee thymikee changed the title [WIP] New landing page, implements #7265 docs: landing page redesign Jan 21, 2019
@cpojer
Copy link
Member

cpojer commented Jan 22, 2019

You are amazing. Thanks for doing this.

@SimenB
Copy link
Member

SimenB commented Jan 22, 2019

Last 2 things, I swear

image

Can we increase the contrast of the placeholder and icon against the background? The screenshot looks OK since it's so zoomed in - on my screen (macbook pro 15") it's pretty hard to read


/blog has .blog .wrapper { max-width: 1100px; } which makes it more narrow than all other pages. Just removing that looks OK to me (the blog text will wrap due to the toc added on the right side, but it already moves to the left when opening it, so it changes now as well).
It looks pretty dumb that the header changes width, at least

normal:
image

blog:
image

EDIT: I lied, one more

Does it make sense to add a small border to the header?

Current:
image

My suggestion (just border-bottom: 1px solid lightgrey;, can probably reuse some color from somewhere else)

image

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@SimenB SimenB merged commit abf9a6c into jestjs:master Jan 25, 2019
@montogeek
Copy link
Contributor Author

Thanks!

@orta
Copy link
Member

orta commented Jan 25, 2019

@montogeek - you can now claim the bounty mentioned in #7265 (comment) <3 thanks!

@montogeek montogeek deleted the new_landing_page branch January 25, 2019 21:26
@montogeek
Copy link
Contributor Author

@orta Thanks to you and the team!

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants