-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: landing page redesign #7566
Conversation
So cool! It's deployed here: https://deploy-preview-7566--jest-preview.netlify.com/
Will be improved in the next version: https://docusaurus.io/blog/2018/09/11/Towards-Docusaurus-2#layout Not sure if an alpha is published, or viable to use? |
<MarkdownBlock> | ||
<translate> | ||
A lot of people! With | ||
[8.5m](https://www.npmjs.com/package/jest) downloads in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way of keeping these numbers updated automatically?
Might be a cool docusaurus feature (showing stats from npm and github) - we already tell docusaurs what our package is named and what repo it's hosted at, /cc @endiliey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that would be really useful
Do'h, I forgot to uncomment my progress :/ |
That's good to know, It is there any progress or proposition about how exactly it is going to be? |
I think to one way to simplify the header CSS, is to make the custom nav CSS only affect the index page - then the rest of the pages can use the navigation bar etc. Which at least scopes the hacks to a single page. |
I think Jest's philosophy hasn't changed much over the years:
How about:
? |
The cards are fantastic. I have some thoughts on how I think it could lead to a better first impression:
|
Done. I reduced the time for the first animation to 2.5 seconds. Any shorter and there’s significant jank on slower clients. Specifically, Firefox has trouble with the initial animation when assets are slow to load and I imagine this could be fixed by inlining the svg logos, but doing so is difficult because I'm doing everything in a dangerouslySetInnerHTML script tag.
Done. Don’t read the code too closely 🤪 |
… nice margin on the front jset logo
Thanks for the reminder, fixed! |
Other than those minor things, I love it. Shipit! |
OK, I've shipped all of those changes too 👍 |
(I still think it would be cool to land together with the blog post for Jest 24, feel free to ignore if you disagree, though) |
Thanks for making those changes but seems like the green text doesn't have a hover style still. I agree with @SimenB it would be awesome to land together; and mention it in the blog post, but if you think we should do it separately I'm ok with that too. One thing that @gaearon brought up was not re-running the full animation on subsequent reloads. I'm wondering if we could disable the animation to only play once in an hour or once in a day; and possibly speed it up on every re-visit of the site, indicating that the "test run" gets faster each time. I think that would be a cool gimmick using localStorage. What do you think? |
One more on the headlines:
|
Oops, missed the hover state - fixed.
When I tested this site on folks at our Peer Labs all but one immediately re-watched the animation was by reloading the page. I think disabling it on the second time would end up making that a bit disappointing (or feel buggy). So, I've made 2nd runs have half the base wait-time that the 1st run has 👍 |
You are amazing. Thanks for doing this. |
Last 2 things, I swear Can we increase the contrast of the placeholder and icon against the background? The screenshot looks OK since it's so zoomed in - on my screen (macbook pro 15") it's pretty hard to read
EDIT: I lied, one more Does it make sense to add a small border to the header? My suggestion (just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
Thanks! |
@montogeek - you can now claim the bounty mentioned in #7265 (comment) <3 thanks! |
@orta Thanks to you and the team! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Implements new landing page as discussed in #7265
Test plan
Run website locally, make sure it looks as the design. Preview: https://deploy-preview-7566--jest-preview.netlify.com/
Dec 30 progress:
ToDo:
Notes:
Docusaurus fulfills its purpose, but its CSS architecture leaves much to be desired, making really hard to make some changes, also it doesn't support custom Navigation bar, only
Footer
, I am expressing these concerns because you will find some ugly CSS that could be completely avoided if Docusaurus was different.