-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Troubleshooting.md #6927
Conversation
With the existing launch configuration, VS Code automatically appends `--inspect-brk=<random_port>` resulting in a command like `node --inspect-brk ${workspaceRoot}/node_modules/.bin/jest --runInBand --inspect-brk=35370`. This does not work because the debugger is listening on port 9229, but Code is attempting to attach to it on port 35370. Adding the port parameter prevents Code from automatically appending the `--inspect-brk` flag and instructs Code attach to the debugger on port 9229.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I assume the same issue applies to Windows, but I am not in a position to test it.
Codecov Report
@@ Coverage Diff @@
## master #6927 +/- ##
=======================================
Coverage 66.97% 66.97%
=======================================
Files 250 250
Lines 10379 10379
Branches 4 4
=======================================
Hits 6951 6951
Misses 3427 3427
Partials 1 1 Continue to review full report at Codecov.
|
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
With the existing launch configuration, VS Code automatically appends
--inspect-brk=<random_port>
resulting in a command likenode --inspect-brk ${workspaceRoot}/node_modules/.bin/jest --runInBand --inspect-brk=35370
. This does not work because the debugger starts listening on port 9229, but Code attempts to attach to it on port 35370 (or whatever random port number it has selected).Adding the port parameter prevents Code from automatically appending the
--inspect-brk
flag and instructs Code attach to the debugger on port 9229.I don't think I'll need to update CHANGELOG.md for this, will I?
Test plan
This change does not include code per se, but I have run the launch configuration in my project and observed that it works properly.