Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade prettier #6344

Merged
merged 1 commit into from
May 30, 2018
Merged

upgrade prettier #6344

merged 1 commit into from
May 30, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 29, 2018

Summary

Mostly prettier/prettier#4440

Test plan

N/A

@SimenB SimenB requested a review from orta as a code owner May 29, 2018 19:25
mattphillips
mattphillips reviewed May 29, 2018
View reviewed changes
e2e/__tests__/__snapshots__/each.test.js.snap Outdated
@@ -29,7 +29,7 @@ exports[`shows error message when not enough arguments are supplied to tests 1`]

Missing 1 arguments

at packages/jest-each/build/bind.js:81:17
at packages/jest-each/build/bind.js:82:17
Copy link
Contributor

@mattphillips mattphillips May 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB I'm about to open a PR with a similar change to this. When you have some time whenever can you help me update this error point to userland in the tests? (If thats possible)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fo sho!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #6347

rickhanlonii
rickhanlonii approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #6344 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6344   +/-   ##
=======================================
  Coverage   63.63%   63.63%           
=======================================
  Files         226      226           
  Lines        8648     8648           
  Branches        4        3    -1     
=======================================
  Hits         5503     5503           
  Misses       3144     3144           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/reporters/utils.js 90.29% <ø> (ø) ⬆️
...est-worker/src/__performance_tests__/workers/pi.js 0% <0%> (ø) ⬆️
packages/jest-editor-support/src/Runner.js 71.73% <100%> (ø) ⬆️
packages/jest-validate/src/example_config.js 60% <0%> (ø) ⬆️
packages/jest-validate/src/validate_cli_options.js 62.79% <0%> (ø) ⬆️
packages/jest-runtime/src/index.js 72.89% <0%> (ø) ⬆️
packages/jest-haste-map/src/module_map.js 87.5% <0%> (ø) ⬆️
packages/jest-config/src/defaults.js 92.85% <0%> (ø) ⬆️
packages/jest-cli/src/test_scheduler.js 37.89% <0%> (ø) ⬆️
packages/jest-environment-node/src/index.js 78.78% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2307643...19ab238. Read the comment docs.

@cpojer
Copy link
Member

cpojer commented May 30, 2018

please rebase before merging.

@SimenB SimenB force-pushed the prettier-1.13 branch 2 times, most recently from d42c947 to e3989ed Compare May 30, 2018 15:39
@SimenB
Copy link
Member Author

SimenB commented May 30, 2018

Gonna hold off on merging until prettier/prettier#4602 is fixed and released. I'll rebase and merge at that time

@ikatyang ikatyang mentioned this pull request May 30, 2018
Merged
@SimenB
Copy link
Member Author

SimenB commented May 30, 2018

image

I'm SO happy prettier supports data tables! So good 😍

@SimenB SimenB merged commit 6ad3f84 into jestjs:master May 30, 2018
@SimenB SimenB deleted the prettier-1.13 branch May 30, 2018 18:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattphillips mattphillips mattphillips left review comments

@cpojer cpojer cpojer approved these changes

@rogeliog rogeliog rogeliog approved these changes

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SimenB @codecov-io @cpojer @rogeliog @rickhanlonii @mattphillips @facebook-github-bot