Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snapshot Extensions References #5842

Merged
merged 3 commits into from
Apr 9, 2018

Conversation

sidferreira
Copy link

Summary

Based on #1650, I wanted a way to add a ios / android / whatever text to snapshot's extension.
The first take was to fix the many places that snap and .snap are defined to avoid a repeated work.

Test plan

Still WIP as I would like maintainers' input about how to tackle this issues.

@codecov-io
Copy link

Codecov Report

Merging #5842 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5842      +/-   ##
==========================================
- Coverage   63.74%   63.72%   -0.03%     
==========================================
  Files         216      216              
  Lines        7941     7942       +1     
  Branches        3        4       +1     
==========================================
- Hits         5062     5061       -1     
- Misses       2878     2880       +2     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/lib/is_valid_path.js 100% <ø> (ø) ⬆️
packages/jest-resolve-dependencies/src/index.js 97.82% <ø> (-2.18%) ⬇️
packages/jest-runtime/src/index.js 73.23% <ø> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7108ed...44a75a7. Read the comment docs.

@sidferreira
Copy link
Author

@SimenB I was checking the coverage effects... it reduced in two files, but it sounds like a false negative... Trying to figure out how to improve...

@cpojer cpojer merged commit c87fcf5 into jestjs:master Apr 9, 2018
@sidferreira sidferreira deleted the SNAPSHOT_EXTENSIONS branch April 9, 2018 22:01
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants