Lint markdown in CI #5645
Lint markdown in CI #5645
Conversation
| @@ -85,11 +85,12 @@ | |||
| "jest-coverage": "yarn jest --coverage", | |||
| "lint": "eslint . --cache --ext js,md", | |||
| "lint-es5-build": "eslint --no-eslintrc --no-ignore --env=browser packages/*/build-es5", | |||
| "lint:md": "prettier docs/**/*.md packages/*/README.md packages/*/docs/**/*.md website/blog/*.md .github/*.md CHANGELOG.md CONTRIBUTING.md website/README.md README.md --write", | |||
| "lint:md": "prettier '**/*.md' --write", | |||
There was a problem hiding this comment.
I confirmed that these two commands are equivalent, not sure what we were filtering before
There was a problem hiding this comment.
We were supposed to not edit README.md, seems like that changed
There was a problem hiding this comment.
🤔 README.md is the last file listed in the original command
There was a problem hiding this comment.
Added in #5378, see #4853 (comment) for why it was excluded
|
Got a timeout on CI, we should probably adjust the failing test. |
| @@ -85,11 +85,12 @@ | |||
| "jest-coverage": "yarn jest --coverage", | |||
| "lint": "eslint . --cache --ext js,md", | |||
| "lint-es5-build": "eslint --no-eslintrc --no-ignore --env=browser packages/*/build-es5", | |||
| "lint:md": "prettier docs/**/*.md packages/*/README.md packages/*/docs/**/*.md website/blog/*.md .github/*.md CHANGELOG.md CONTRIBUTING.md website/README.md README.md --write", | |||
| "lint:md": "prettier '**/*.md' --write", | |||
| "lint:md:ci": "prettier '**/*.md' --list-different", | |||
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR adds a check to CI for failed markdown linting
Test plan
N/A